fix/deep review improvements#36
Merged
Merged
Conversation
Patel230
commented
Jun 11, 2026
Patel230
commented
Contributor
- chore: untrack local AI assistant dirs and coverage artifacts
- docs: fix project name in first-time guide, document Go version
- docs(checkpoint): document MustCheckpointID constant-only contract
- docs(explain): expand nolint:nilerr justifications with fallback behavior
- ci: upload deadcode report and add hook bench target
Remove .opencode/, .codex/, and .gemini/ from version control and ignore them going forward, along with coverage.out/coverage.html which were already gitignored but coverage.out had previously been tracked in some clones. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Replace stale "Entire" references with "Trace" in docs/first-time-contributors.md (including the section anchor link) and document the Go 1.26.4 toolchain requirement in CONTRIBUTING.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
NewCheckpointID already provides the error-returning constructor and all runtime call sites use it; MustCheckpointID has no non-test callers. Document that it is reserved for constants and test fixtures so panics cannot reach production paths. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…vior Each suppressed nil-error return now documents why swallowing the error is intentional and what the caller-visible fallback is (not-found reporting instead of raw git/internal errors). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.