Skip to content

[MUI2] Add basic magnet implementation#4599

Merged
gustovafing merged 6 commits intomui2-refactorfrom
jj/port-magnets
Apr 4, 2026
Merged

[MUI2] Add basic magnet implementation#4599
gustovafing merged 6 commits intomui2-refactorfrom
jj/port-magnets

Conversation

@jurrejelle
Copy link
Copy Markdown
Contributor

@jurrejelle jurrejelle commented Feb 10, 2026

What

Basic, almost 1:1 implementation of magnets from LDLib to MUI

How Was This Tested

java_7czScCa85G.mp4

Currently, this naively re-builds the filter. This is because the filter's MUI code creates a ModularPanel, but I need to embed it into the magnet's UI. It's worth considering if we want to somehow de-duplicate this.

@jurrejelle jurrejelle added type: refactor Suggestion to refactor a section of code 1.20.1 Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. labels Feb 10, 2026
@jurrejelle jurrejelle mentioned this pull request Feb 10, 2026
@github-actions github-actions bot added the Tests: Passed Game Tests have passed on this PR label Feb 10, 2026
@jurrejelle jurrejelle marked this pull request as ready for review February 19, 2026 16:46
@jurrejelle jurrejelle requested a review from a team as a code owner February 19, 2026 16:46
@jurrejelle jurrejelle closed this Feb 19, 2026
@jurrejelle jurrejelle reopened this Feb 19, 2026
# Conflicts:
#	src/main/java/com/gregtechceu/gtceu/common/network/ModularNetwork.java
@gustovafing gustovafing merged commit dd1d78e into mui2-refactor Apr 4, 2026
3 of 4 checks passed
@gustovafing gustovafing deleted the jj/port-magnets branch April 4, 2026 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.20.1 Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. Tests: Passed Game Tests have passed on this PR type: refactor Suggestion to refactor a section of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants