Skip to content

add SaveToItemStack annotation to data sync system#4744

Closed
gustovafing wants to merge 8 commits into1.20.1from
gus/save-to-stack-annotation
Closed

add SaveToItemStack annotation to data sync system#4744
gustovafing wants to merge 8 commits into1.20.1from
gus/save-to-stack-annotation

Conversation

@gustovafing
Copy link
Copy Markdown
Member

What

Adds the SaveToItemStack annotation to the data sync system. This annotation existed in the ldlib sync system but wasn't initially ported over.

@gustovafing gustovafing requested a review from a team as a code owner March 20, 2026 00:37
@gustovafing gustovafing added type: feature New feature or request bundled for a 0.X.0 Update 1.20.1 Release: Major - 0.X.0 Releases focused on Content, changes to gameplay; While maintaining mostly API stability. labels Mar 20, 2026
@github-actions github-actions bot added the Tests: Passed Game Tests have passed on this PR label Mar 20, 2026
Copy link
Copy Markdown
Contributor

@screret screret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't the sync package supposed to be com.gregtechceu.gtceu.api.sync?

Comment thread src/main/java/com/gregtechceu/gtceu/api/machine/MetaMachine.java Outdated
Comment thread src/main/java/com/gregtechceu/gtceu/api/machine/feature/IDropSaveMachine.java Outdated
Comment thread src/main/java/com/gregtechceu/gtceu/api/machine/MetaMachine.java
@gustovafing
Copy link
Copy Markdown
Member Author

I've changed my mind I don't think this is needed

@gustovafing gustovafing closed this Apr 5, 2026
@gustovafing gustovafing deleted the gus/save-to-stack-annotation branch April 5, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.20.1 Release: Major - 0.X.0 Releases focused on Content, changes to gameplay; While maintaining mostly API stability. Tests: Passed Game Tests have passed on this PR type: feature New feature or request bundled for a 0.X.0 Update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants