Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
/describe |
Owner
Author
|
/review |
Owner
Author
|
/improve |
Code Review by QodoNew Review StartedThis review has been superseded by a new analysisⓘ The new review experience is currently in Beta. Learn more |
Review Summary by QodoImplement neon night dark theme with enhanced UI styling and theme toggle
WalkthroughsDescription• Implemented neon night dark theme with neon green accent and neon pink secondary colors • Refactored CSS variables system for light/dark mode consistency using oklch color space • Added theme toggle functionality in header with next-themes integration • Enhanced UI components with dark mode styling and glow effects for search tabs • Updated version to 2.4.0 and added changelog entry • Paused tag cronjob workflow temporarily Diagramflowchart LR
A["CSS Variables<br/>Light/Dark Mode"] -->|"Neon Green Accent<br/>Neon Pink Secondary"| B["Dark Theme<br/>Styling"]
C["Header Component"] -->|"Theme Toggle"| D["next-themes<br/>Integration"]
B --> E["Updated Components<br/>Header, Footer, Sidebar"]
E --> F["Enhanced Visual<br/>Glow Effects"]
G["Version 2.4.0"] -->|"Changelog"| H["Release Notes"]
I["Tagging Workflow"] -->|"Paused"| J["Cron Job"]
File Changes1. apps/web/src/globals.css
|
Code Review by Qodo
1. Header exposes Light Mode toggle
|
Code Review by Qodo
1. --primary not neon green
|
|
PR Description updated to latest commit (d5ea79e)
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+100
to
+113
| <ExpandableButton | ||
| buttonKey="theme" | ||
| expanded={expanded} | ||
| label={theme === 'dark' ? '라이트 모드' : '다크 모드'} | ||
| icon={ | ||
| <span className="relative h-4 w-4"> | ||
| <Sun className="absolute h-4 w-4 scale-100 rotate-0 transition-all dark:scale-0 dark:-rotate-90" /> | ||
| <Moon className="absolute h-4 w-4 scale-0 rotate-90 transition-all dark:scale-100 dark:rotate-0" /> | ||
| </span> | ||
| } | ||
| onClick={() => | ||
| handleExpandableClick('theme', () => setTheme(theme === 'dark' ? 'light' : 'dark')) | ||
| } | ||
| /> |
There was a problem hiding this comment.
1. Header exposes light mode toggle 📎 Requirement gap ≡ Correctness
The updated Header adds a prominent theme toggle that enables switching to Light Mode, so Light Mode is not removed/minimized as required. This undermines the requirement that the Neon/Night experience be primarily dark by default with Light Mode not prominently available.
Agent Prompt
## Issue description
The header now provides a direct Light Mode toggle (`setTheme(... 'light' ...)`), which conflicts with the requirement that Light Mode be removed or minimized.
## Issue Context
Dark Mode is set as default in `ThemeProvider`, but the UI still exposes a prominent toggle that enables Light Mode.
## Fix Focus Areas
- apps/web/src/Header.tsx[100-113]
- apps/web/src/app/layout.tsx[134-140]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
3
to
+6
| on: | ||
| schedule: | ||
| - cron: "0 14 * * *" # 한국 시간 23:00 실행 (UTC+9 → UTC 14:00) | ||
| workflow_dispatch: | ||
| # schedule: | ||
| # - cron: "0 14 * * *" # 한국 시간 23:00 실행 (UTC+9 → UTC 14:00) | ||
| # workflow_dispatch: |
There was a problem hiding this comment.
2. Workflow has no triggers 🐞 Bug ☼ Reliability
.github/workflows/tagging_song.yml now has an empty on: block (only comments), meaning the workflow has no configured events and cannot run. This breaks both scheduled tagging and manual dispatch for the tagging job.
Agent Prompt
## Issue description
`.github/workflows/tagging_song.yml` currently has `on:` with no enabled events (only commented lines), so the workflow cannot be triggered.
## Issue Context
The PR description mentions pausing the tagging cron job. Pausing the schedule is fine, but the workflow file still must define at least one trigger event to remain valid/runnable (e.g., keep `workflow_dispatch` so it can be run manually).
## Fix Focus Areas
- .github/workflows/tagging_song.yml[1-7]
### Suggested change
Re-enable at least one trigger, for example:
```yml
on:
workflow_dispatch:
# schedule:
# - cron: "0 14 * * *"
```
(or re-enable `schedule` too if the cron should continue).
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+117
to
+126
| --background: oklch(0.15 0.01 260); | ||
| --foreground: oklch(0.9 0 0); | ||
| --card: oklch(0.2 0.01 260); | ||
| --card-foreground: oklch(0.9 0 0); | ||
| --popover: oklch(0.2 0.01 260); | ||
| --popover-foreground: oklch(0.9 0 0); | ||
| --primary: oklch(0.9 0 0); | ||
| --primary-foreground: oklch(0.15 0.01 260); | ||
| --secondary: oklch(0.65 0.2 350); /* 네온 핑크 */ | ||
| --secondary-foreground: oklch(0.95 0 0); |
There was a problem hiding this comment.
1. --primary not neon green 📎 Requirement gap ≡ Correctness
In dark mode, --primary is set to oklch(0.9 0 0) instead of the required primary accent oklch(0.75 0.2 145). Components that use bg-primary (e.g., default shadcn buttons) will not reflect the specified neon primary accent globally.
Agent Prompt
## Issue description
Dark theme `--primary` is not set to the required neon primary accent (`oklch(0.75 0.2 145)`), so global primary styling will not match the neon spec.
## Issue Context
The compliance spec requires: primary accent `oklch(0.75 0.2 145)`, secondary `oklch(0.65 0.2 350)`, background `oklch(0.15 0.01 260)` applied globally.
## Fix Focus Areas
- apps/web/src/globals.css[117-130]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+37
to
+46
| <Button | ||
| variant="outline" | ||
| size={isExpanded ? 'default' : 'icon'} | ||
| className="dark:hover:bg-primary dark:hover:text-primary-foreground transition-all" | ||
| disabled={disabled} | ||
| onClick={onClick} | ||
| > | ||
| {icon} | ||
| {isExpanded && label} | ||
| </Button> |
There was a problem hiding this comment.
2. Buttons missing glow effect 📎 Requirement gap ≡ Correctness
Updated buttons (e.g., the new ExpandableButton and other outline buttons) add hover color changes but do not add a glow (box-shadow/filter) in active/hover states. This falls short of the requirement that buttons (in addition to active tabs) display a subtle neon glow.
Agent Prompt
## Issue description
Buttons updated/introduced in this PR do not apply a neon glow in hover/active/selected states (only background/text changes).
## Issue Context
Compliance requires subtle glow effects on both buttons and active tabs. Glow tokens exist (`--glow-accent`, `--glow-secondary`) but are not applied to buttons.
## Fix Focus Areas
- apps/web/src/Header.tsx[37-46]
- apps/web/src/Sidebar.tsx[142-146]
- apps/web/src/app/search/JpnArtistList.tsx[41-44]
- apps/web/src/globals.css[149-155]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
3
to
+6
| on: | ||
| schedule: | ||
| - cron: "0 14 * * *" # 한국 시간 23:00 실행 (UTC+9 → UTC 14:00) | ||
| workflow_dispatch: | ||
| # schedule: | ||
| # - cron: "0 14 * * *" # 한국 시간 23:00 실행 (UTC+9 → UTC 14:00) | ||
| # workflow_dispatch: |
There was a problem hiding this comment.
3. Workflow triggers removed 🐞 Bug ☼ Reliability
.github/workflows/tagging_song.yml now has an on: key with no actual events (only comments), so the workflow has no valid trigger and will be rejected/disabled by GitHub Actions. This stops the scheduled/manual song-tagging automation entirely.
Agent Prompt
## Issue description
`.github/workflows/tagging_song.yml` has an `on:` section with no actual triggers (only comments). GitHub Actions workflows must declare at least one event trigger; otherwise the workflow is invalid/disabled and will never run.
## Issue Context
Other workflows in `.github/workflows/` define triggers under `on:` (e.g., `schedule`, `workflow_dispatch`). This file should follow the same structure even if the cron needs to be paused.
## Fix Focus Areas
- .github/workflows/tagging_song.yml[1-7]
## Suggested fix
If you want to pause the cron but keep the workflow valid, restore at least `workflow_dispatch:` under `on:` and keep `schedule:` commented out. If you want it completely disabled, keep `workflow_dispatch:` but gate execution (e.g., job-level `if: false`) so the YAML stays valid.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
📌 PR 제목
[Feat] : 네온 나이트 다크 테마 적용
📌 변경 사항
globals.css)HomePage.tsx)💬 추가 참고 사항
PR Type
Enhancement
Description
Implement neon night dark theme with neon green accent and neon pink secondary colors
Refactor CSS variables system for light/dark mode consistency using oklch color space
Add theme toggle functionality to header with next-themes integration
Update version to 2.4.0 and add changelog entry
Pause tag cronjob workflow temporarily
Apply neon glow effects to search tabs and update component styling
Diagram Walkthrough
File Walkthrough
13 files
Refactor CSS variables for neon night themeAdd theme toggle and expandable button UIIntegrate ThemeProvider and update stylingAdd neon glow effects to search tabsAdd border styling to footerUpdate logout button dark mode stylingUpdate button colors to use accent themeReplace hardcoded blue with accent colorUpdate loading overlay background colorReplace gray text with muted-foregroundUpdate hover colors to use accent themeAdd dark mode hover styling to buttonReplace hardcoded gray with muted-foreground2 files
Update version to 2.4.0Pause tag cronjob workflow execution1 files
Add version 2.4.0 changelog entry1 files
Update sitemap lastmod timestamp