Repository navigation
A generated docs/workflow.md maps each caller to the bundled rules that fire there - #418
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 32 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
=======================================
Coverage 94.85% 94.85%
=======================================
Files 52 52
Lines 27259 27259
=======================================
Hits 25857 25857
Misses 1402 1402 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
HackingGate
added a commit
that referenced
this pull request
Oct 23, 2026
…rrent passes again (#419) Upstream tagged v0.17.2 while #417 and #418 were in CI, and the manual-stage pin check failed both on a line neither touched. ruff check and ruff format under v0.17.2 report nothing new over the whole tree. Claude-Session: https://claude.ai/code/session_01YTpdnDJrf2hT6hFyjS7evA
…o the command it ends in, and lists the bundled rules that fire at each caller tests/workflow_doc.rs renders the page from the binary's own `rules --sets --json` and `rules --effective --json` and fails while the committed file differs; UPHOLD_WORKFLOW_GOLDEN=bless rewrites it. README.md links it. Claude-Session: https://claude.ai/code/session_01YTpdnDJrf2hT6hFyjS7evA
HackingGate
force-pushed
the
workflow-doc
branch
from
October 23, 2026 13:41
ceb1e7c to
0a1ecf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
docs/workflow.md, a caller map: a Mermaid flowchart from each entry point (git commit and push hooks, shimmed commands, agent tool calls, CI and manual) to the uphold command it ends in, then one table per caller of the bundled rules that fire there (rule id, set, first sentence of the message).tests/workflow_doc.rsrenders it and fails while the committed file differs;UPHOLD_WORKFLOW_GOLDEN=bless cargo test --test workflow_docrewrites it. The tables come fromrules --sets --json(ids, sets, messages) andrules --effective --jsonover a scratch repository inheriting every set (where each rule runs, as the engine'sRule::seamsanswers). The diagram and surrounding prose are constants in the test.The brief said
uphold hooks --installcovers lefthook or prek; the code refuses lefthook, which owns its hooks (written byuphold init --lefthook). The page says so.https://claude.ai/code/session_01YTpdnDJrf2hT6hFyjS7evA