This repository was archived by the owner on Jul 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Add Tuparg - semi-typesafe fast variadic argument iteration support #9
Draft
dekrain
wants to merge
4
commits into
HackyTeam:dev
Choose a base branch
from
dekrain:feature-tuparg
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| #pragma once | ||
|
|
||
| #include "Types.hpp" | ||
| #include "Utility.hpp" | ||
| #include "Result.hpp" | ||
| #include <cassert> | ||
|
|
||
| namespace hsd { | ||
|
|
@@ -10,7 +10,7 @@ namespace hsd { | |
| void* addr; | ||
|
|
||
| template <typename X> | ||
| X& getnext() { | ||
| X& getnext_unsafe() { | ||
| assert(addr); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What happens if
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's more of a safety measure. The program normally shouldn't allow this function to be called with null pointer, but if it gets called (by some other way than |
||
|
|
||
| X* p = reinterpret_cast<X*>(addr); | ||
|
|
@@ -23,6 +23,13 @@ namespace hsd { | |
| return *p; | ||
| } | ||
|
|
||
| template <typename X> | ||
| Result<reference<X>, runtime_error> getnext() { | ||
| if (!addr) | ||
| return runtime_error("Extracting value past end of the container"); | ||
| return Result<reference<X>, runtime_error>(getnext_unsafe<X>(), ok_tag_t{}); | ||
| } | ||
|
|
||
| bool operator==(const xtuple_iterator& o) const { | ||
| return addr == o.addr; | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.