fix download of screenshots not working because the last Chrome window closes the popup#7
Open
StefanTirea wants to merge 2 commits into
Open
Conversation
… Chrome window closes the popup
StefanTirea
force-pushed
the
private/fix-screenshots-not-downloaded
branch
from
7f592d7 to
b768acb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this would be a quick and dirty fix for the issue described in #6.
The chrome extension popup is closed when the last chrome window is closed. My fix moves closing the window at the end when the whole capture process is completed (as a workaround).
It would be better to move all the window capture + processing logic into a service worker (background worker) to better prevent this issue from happening.