Fix: add null guard after ReadAll() in GetRaceDataOfDay#20
Open
HashidaTKS wants to merge 1 commit into
Open
Conversation
…llReferenceException ReadAll() returns null when the XML file does not exist. GetRaceDataOfDay was accessing currentHoldingInformation.HoldingData without a null check, which would throw NullReferenceException on first run or after cache reset. Add an explicit null check and yield break to handle the no-data case safely. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題点
RaceDataManager.GetRaceDataOfDay()でholdingInformationRepository.ReadAll()の戻り値を null チェックせずにcurrentHoldingInformation.HoldingData.Where(...)を呼び出していた。ReadAll()は XMLファイルが存在しない場合（初回起動時やキャッシュリセット後など）にnullを返すため、NullReferenceExceptionが発生する可能性があった。改善内容
ReadAll()の結果がnullの場合はyield breakで早期リターンするガード節を追加GetAndStoreRaceDataOfDay()は既に?? new HoldingInformation(...)で対処済みのため変更不要Test plan
holding_info.xmlが存在しない状態でGetRaceDataOfDayを呼び出しても例外が発生しないことを確認🤖 Generated with Claude Code