Fix: add XmlReaderSettings to prevent XXE attacks#24
Open
HashidaTKS wants to merge 1 commit into
Open
Conversation
XmlReader.Create(filePath) without settings uses default settings that may allow DTD processing and external entity resolution, making the application vulnerable to XXE (XML External Entity) injection attacks. Set DtdProcessing = Prohibit and XmlResolver = null to explicitly disable DTD processing and external entity resolution. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題点
XmlSerializerWrapper.Deserialize()でXmlReader.Create(filePath)をXmlReaderSettingsなしで呼び出していた。デフォルト設定では DTD 処理と外部エンティティの解決が有効になる場合があり、外部から操作された XML ファイルを読み込む際に XXE (XML External Entity) 攻撃が成立する可能性があった。
改善内容
XmlReaderSettingsを追加しDtdProcessing = DtdProcessing.Prohibitを設定XmlResolver = nullで外部エンティティの解決を無効化Test plan
🤖 Generated with Claude Code