Fix: replace O(n*m) linear scan with O(n+m) dictionary lookup in GetSameTicketOddsData#36
Open
HashidaTKS wants to merge 1 commit into
Open
Fix: replace O(n*m) linear scan with O(n+m) dictionary lookup in GetSameTicketOddsData#36HashidaTKS wants to merge 1 commit into
HashidaTKS wants to merge 1 commit into
Conversation
…ameTicketOddsData The original implementation called targetFromList.FirstOrDefault() inside a foreach over targetNeedList, resulting in O(n*m) complexity. For typical race data with many odds entries this becomes a bottleneck in simulation. Build a Dictionary<string, OddsDatum> keyed by the horse number signature (comma-joined, sorted for order-independent ticket types) from froms before the loop, reducing the overall complexity to O(n+m). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題点
EnumerableUtils.GetSameTicketOddsData()でfromsのリストを毎要素FirstOrDefault()で線形探索していた（line 28）。needsのサイズを n、fromsのサイズを m とすると O(n*m) の計算量となり、シミュレーションで大量のオッズデータを処理する際にボトルネックになる。改善内容
fromsをループ前にDictionary<string, OddsDatum>に変換（O(m)）TryGetValueで O(1) ルックアップ → 全体で O(n+m)Test plan
nullが返されることを確認🤖 Generated with Claude Code