Fix: Remove debug console.log and mark decorative arrows as hidden#161
Open
WaterXiao-git wants to merge 2 commits into
Open
Fix: Remove debug console.log and mark decorative arrows as hidden#161WaterXiao-git wants to merge 2 commits into
WaterXiao-git wants to merge 2 commits into
Conversation
Remove a debug console.log that was left in the creator submit handler, which ships to the client console in production. Closes Heliobond#153
Wrap ← arrow characters in span with aria-hidden so screen readers
only announce the text label ('Back to projects') instead of the
literal arrow glyph.
Closes Heliobond#105
WaterXiao-git
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two accessibility and cleanup fixes:
Closes #153 and #105