update tui Cargo.toml for HarmonyOS build#4566
Conversation
1. move portable-pty crate from target_evn ohos to cfg("unix") in
tui Cargo.toml.
2. the newest portable-pty 0.9 and nix transitived fulfill requirements
of musl, so both of them lifed from the gate.
|
Thanks @shenyongqing for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
Hmbown
left a comment
Hmbown
left a comment
There was a problem hiding this comment.
Thank you for testing on a HarmonyOS PC. I audited this exact commit against current main and cannot merge it as written yet.
Two release-blocking points:
-
Moving portable-pty into cfg(unix) does not enable or repair an OHOS code path. Current main still compiles the terminal_session module, shell PTY imports and variants, child PTY environment path, and persistent terminal tool registration out under cfg(target_env = "ohos"). The added dependency is therefore unused on the OHOS release build; ordinary non-PTY shell execution was already the supported path and has a prior real-SDK cargo-check receipt.
-
The patch weakens check-ohos-deps.sh while leaving docs/HarmonyOS.md explicitly saying portable-pty and nix 0.28/0.29 are excluded and terminal/* is unavailable. That would leave the guard, documentation, and shipped capability disagreeing.
A focused package check confirms portable-pty 0.9.0 itself resolves for aarch64-unknown-linux-ohos, which is useful evidence, but it does not show that this patch changes Codewhale. Please add the exact rustc -vV / target triple and before-versus-after Codewhale build commands and errors from the HarmonyOS machine. If the intended change is to enable persistent PTY tools, that needs the matching cfg removals, runtime tests, sandbox/clipboard audit, and documentation update under #2970; those residuals are explicitly v0.9.2 scope. If the intent is only to fix a current build, we need a reproducer that fails on current main and passes on this head.
I am leaving the PR and source branch intact so we can incorporate the real hardware evidence safely.
|
Hi Hunter,
It turns out that in the latest version @6cd2953, compilation on HarmonyOS PC succeeds without the need for a patch, and the behavior is expected in a short running. Here are the details regarding the HarmonyOS PC compilation environment what i got right now， the following is the output of `rustc -vV`:
/storage/Users/currentUser % rustc -vV
rustc 1.95.0 (59807616e 2026-04-14) (built from a source tarball)
binary: rustc
commit-hash: 59807616e1fa2540724bfbac14d7976d7e4a3860
commit-date: 2026-04-14
host: aarch64-unknown-linux-ohos
release: 1.95.0
LLVM version: 22.1.2
/storage/Users/currentUser % uname -a
HarmonyOS localhost HongMeng Kernel 1.12.0 #1 SMP Tue Jun 23 02:15:22 UTC 2026 aarch64 Toybox
So to close the PR is ok for me.
Regards,
Yongqing
… On Jul 20, 2026, at 20:52, Hunter Bown ***@***.***> wrote:
@Hmbown requested changes on this pull request.
Thank you for testing on a HarmonyOS PC. I audited this exact commit against current main and cannot merge it as written yet.
Two release-blocking points:
Moving portable-pty into cfg(unix) does not enable or repair an OHOS code path. Current main still compiles the terminal_session module, shell PTY imports and variants, child PTY environment path, and persistent terminal tool registration out under cfg(target_env = "ohos"). The added dependency is therefore unused on the OHOS release build; ordinary non-PTY shell execution was already the supported path and has a prior real-SDK cargo-check receipt.
The patch weakens check-ohos-deps.sh while leaving docs/HarmonyOS.md explicitly saying portable-pty and nix 0.28/0.29 are excluded and terminal/* is unavailable. That would leave the guard, documentation, and shipped capability disagreeing.
A focused package check confirms portable-pty 0.9.0 itself resolves for aarch64-unknown-linux-ohos, which is useful evidence, but it does not show that this patch changes Codewhale. Please add the exact rustc -vV / target triple and before-versus-after Codewhale build commands and errors from the HarmonyOS machine. If the intended change is to enable persistent PTY tools, that needs the matching cfg removals, runtime tests, sandbox/clipboard audit, and documentation update under #2970 <#2970>; those residuals are explicitly v0.9.2 scope. If the intent is only to fix a current build, we need a reproducer that fails on current main and passes on this head.
I am leaving the PR and source branch intact so we can incorporate the real hardware evidence safely.
—
Reply to this email directly, view it on GitHub <#4566?email_source=notifications&email_token=AGME5ERCVXJAEJQ2URXTMXL5FYI2NA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINZTGUYDOMBRGQY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#pullrequestreview-4735070141>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGME5EXANMBFYTFY5HSSTNT5FYI2NAVCNFSNUABGKJSXA33TNF2G64TZHMYTCMZXG4YTCMZRGE5US43TOVSTWNBZGIYTMMZVGMZTNILWAI>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/AGME5ESOFWVRGXEXQTRYY2D5FYI2NA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINZTGUYDOMBRGQY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> and Android <https://github.com/notifications/mobile/android/AGME5ETP5CVBT3SAO64GNVL5FYI2NA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINZTGUYDOMBRGQY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. Download it today!
You are receiving this because you were mentioned.
|
2 participants
Summary
Compiled codewhale on HarmonyOS PC and got the TUI running successfully again.
Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-featurescargo test --workspace --all-featuresChecklist