Conversation
- Replace removed `indmin_mismatch` with `argmin_mismatch` (RegisterCore v1 renamed it following Julia's indmin→argmin convention) - Replace deprecated 3-arg `ratio(nd, thresh, fillval)` with keyword form `ratio(nd, thresh; fillval=fillval)` (7 sites) - Replace deprecated `mismatch0` with `mismatch_zeroshift` (3 sites) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
SD was the 6th positional argument with a default, inconsistent with qd_rigid and qd_affine where SD is a keyword. Callers using `rotation_gridsearch(..., SD=mySD)` got UndefKeywordError. Moves SD after the semicolon; updates the docstring and gridsearch test. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Version 1.0.0 - CenterIndexedArrays, RegisterCore, RegisterDeformation, RegisterMismatch all bumped to v1 compat - Julia LTS floor raised to 1.10 - CI: use julia-actions/setup-julia@v2, min version matrix entry, codecov v5 with token secret - TagBot: switch to TAGBOT_TOKEN secret Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The convenience overload `qsmooth(img)` previously hardcoded `Float32` as the compute/output eltype. It now defaults to `float(eltype(img))`, so Float64 images stay Float64. Users who need a specific eltype can still call `qsmooth(Float32, img)` explicitly. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Old-signature callers now get a MethodError pointing at the real signatures instead of a hand-written ErrorException. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
qd_affine uses thresh=0.5x (stricter overlap) vs the 0.1x default in qd_translate and qd_rigid because affine's extra degrees of freedom make degenerate low-overlap solutions more likely. Add an explanatory comment at the default and document the default value in the qd_affine and qd_translate docstrings (qd_rigid already had it). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Callers can now pass an image directly instead of wrapping it in CartesianIndices(img). No dispatch ambiguity: the existing CartesianIndices method is strictly more specific. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
These keyword names encode meaningful subspace distinctions: minwidth_rot controls rotation-parameter resolution only (not translation), and minwidth_mat controls linear-map-parameter resolution only. Both are combined internally with a fixed translation minwidth via vcat. Added explanatory notes to the qd_rigid and qd_affine_fine docstrings to make this clear and distinguish from the full-space minwidth in qd_translate. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rotation_gridsearchSDis now a keyword argument; positional callers must update to; SD=mySDqsmooth(img)defaults output eltype tofloat(eltype(img))instead of hardcodedFloat32;default_minrotacceptsAbstractArraydirectly; removed always-erroring deprecated stubs for oldqd_rigid/qd_affinesignatures; documentedthreshdefaults andminwidth_rot/minwidth_matsubspace semanticsTest plan
Pkg.test("RegisterQD")passes (34 tests across 6 test sets; gridsearch tests are slow, ~3–4 min)Test.detect_ambiguities(RegisterQD)returns 0rotation_gridsearch(...; SD=mySD)keyword form works and old positional form raisesMethodError🤖 Generated with Claude Code