fix: preserve indentation for multiline dicts#94
Open
johnsfuller wants to merge 1 commit into
Open
Conversation
Author
|
@TanyaScales not sure if this will be accepted but i did want to make sure y'all's eyes were on it! |
johnsfuller
marked this pull request as ready for review
June 5, 2026 11:18
Author
|
@joeyblake since Tanya seems busy i thought I'd tag you too... not sure if this will be accepted but i did want to make sure y'all's eyes were on it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #93.
Summary
This updates the HubL printer so multiline dicts inherit the indentation of the HubL tag that contains them. The previous printer emitted
{{ ... }}output expressions and inline{% set ... = ... %}tags without aligning nested multiline docs to the enclosing tag column, so dict entries could be printed flush with the page instead of under the expression.Example
Input from
prettier/tests/dicts.html:Formatted output:
The fixture also includes a macro call with multiple dict arguments to cover output expressions with more than one object parameter.
Validation
npm test npx prettier prettier/tests/dicts.html --parser hubl --plugin ./prettier/dist/src/index.js