fix:fix the problem that frontend can not corectly render after ml-ba… - #9877
Open
Dan5N wants to merge 2 commits into
Open
fix:fix the problem that frontend can not corectly render after ml-ba…#9877Dan5N wants to merge 2 commits into
Dan5N wants to merge 2 commits into
Conversation
…ckend return rles
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies how suggestion accept/reject controls are rendered in the Konva image view, aiming to simplify the SuggestionControls implementation by removing the useLayer-driven rendering path (and its Layer usage) and adjusting RegionWrapper integration.
Changes:
- Removed
Layerusage and theuseLayerprop fromSuggestionControls, always rendering controls as aGroup. - Simplified
RegionWrapperby removing the suggestion-context handling andSuggestionControlsrendering. - Cleaned up related imports.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| web/libs/editor/src/regions/RegionWrapper.jsx | Removes suggestion-context consumption and stops rendering SuggestionControls. |
| web/libs/editor/src/components/ImageView/SuggestionControls.jsx | Removes useLayer prop and Layer wrapper; always renders the controls as a Group. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2
to
8
| import { Fragment } from "react"; | ||
|
|
||
| export const RegionWrapper = observer(({ children }) => { | ||
| return ( | ||
| <Fragment> | ||
| {children} | ||
| {suggestion && <SuggestionControls item={item} useLayer={item.type === "brushregion"} />} | ||
| </Fragment> |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
web/libs/editor/src/regions/RegionWrapper.jsx:8
RegionWrapperno longer rendersSuggestionControls(and no longer readsImageViewContext.suggestion), butSuggestionControlsis now unused across the repo and appears to be the only UI that callsannotation.acceptSuggestion/rejectSuggestion. This effectively removes the ability to accept/reject suggestions and seems inconsistent with the PR description ("simplifies ... integration in the RegionWrapper"). Consider restoring theSuggestionControlsrender inRegionWrapper, passing onlyitem(nouseLayer) so the crash fix remains.
export const RegionWrapper = observer(({ children }) => {
return (
<Fragment>
{children}
</Fragment>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ckend return rles
Fixes #9876
the returned rles can correctly processed by frontend now
This pull request simplifies the implementation of the
SuggestionControlscomponent and its integration in theRegionWrapper. The main changes involve removing theuseLayerprop and related conditional logic, resulting in a more straightforward and maintainable codebase.Component simplification and prop removal:
useLayerprop fromSuggestionControlsand all related conditional logic, so the component now always renders its content in a consistent way. [1] [2] [3]RegionWrapperto no longer pass theuseLayerprop or conditionally renderSuggestionControls, further simplifying its logic.Code cleanup:
Layer,ImageViewContext, andSuggestionControls) fromRegionWrapper.jsxand the unusedLayerimport fromSuggestionControls.jsx. [1] [2]