add dependency checks for location deletion for better error messages#197
add dependency checks for location deletion for better error messages#197adamkorynta wants to merge 1 commit into
Conversation
add in savepoint and rollback on delete and ensure cache removal happens last
|
@perrymanmd - I could not reproduce the issue with schema 25.7.1 or the 26.02.17-RC02. I'm wondering if the updates done for the geometry might have inadvertently solved the issue. I tested deleting both base locations and sublocations. I think adding some error handling and a save point might help diagnose the issues if they persist. I did a little reorganizing of the delete_location method. Can you take a look? |
That would not surprise me. |
adamkorynta
requested review from
a team,
rma-rripken and
tlelv
and removed request for
a team,
rma-rripken and
tlelv
| end if; | ||
|
|
||
| if l_delete_action in (cwms_util.delete_key, cwms_util.delete_loc) then | ||
| l_dependency_info := get_delete_dependency_info; |
There was a problem hiding this comment.
this seems like something where we shouldn't do it until the error is raised.
Though I'll grant anyone doing deletes in a tight loop regularly is not doing something remotely sane.
There was a problem hiding this comment.
the intention here was to ward off the reported deadlock and figured the performance hit wouldn't make anyone grumble too much
3 participants
add in savepoint and rollback on delete and ensure cache removal happens last
Fixes #182