Skip to content

Measurements improvements#151

Merged
msweier merged 12 commits into
mainfrom
measurements
Jul 3, 2025
Merged

Measurements improvements#151
msweier merged 12 commits into
mainfrom
measurements

Conversation

@msweier

@msweier msweier commented Jun 13, 2025

Copy link
Copy Markdown
Collaborator

This PR:

  1. Adds datatype check for measurements to ensure a list of dictionaries is supplied.
  2. Reorders the columns returned by the measurement dataframe. For some reason the API returns units first instead of the PKIDs and data. This code seems a bit long for what it does, so I'm open to ideas. I don't want to clutter up the cwms_types.py too much but I don't know of a better way to get the important stuff up front.
  3. Adds a get_measurements_extents function.
  4. Adds an measurement example notebook.

@msweier msweier requested a review from Enovotny June 13, 2025 20:22
Comment thread cwms/measurements/measurements.py Outdated
@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2025

Copy link
Copy Markdown

@msweier msweier merged commit 7da00e2 into main Jul 3, 2025
8 checks passed
@msweier msweier deleted the measurements branch July 3, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants