Fix/desktop startup logs and update#267
Merged
Merged
Conversation
…s an update Accepting "Update & restart" tears the whole stack down and relaunches, but the sandbox VM thread kept staging/downloading the image and booting the VM during the ~minutes-long update download — only to be killed on restart. Now an UPDATING flag is set on accept: start_sandbox_vm bails before staging/boot (and stops the VM if the update lands mid-boot), and a VM-only stop_sandbox_vm() halts an already-running VM while leaving workerd/frontend up so the update-progress bar keeps working.
…tup failures) A Finder-launched .app has no attached terminal, so the workerd/D1 output that explains WHY startup failed (e.g. a port bind error) vanished into inherited stderr. Now spawn_binary pipes + tees each service's stdout/stderr to the console AND a per-boot <app_data>/startup.log (truncated each launch, headed with the chosen control-plane/frontend/d1/sandbox ports). Adds a read_startup_log command so the loading screen can show it when the backend doesn't come up.
…way" - On the startup-failure screen, fetch and display the teed backend server logs (read_startup_log → <app_data>/startup.log) below the port/health summary, so a user (or their nephew) can see WHY the services didn't come up without a terminal. The diag box now scrolls for long logs. - Remove the "Open anyway →" option: proceeding to the dashboard while the required backend (web interface / control plane) is down just yields a broken app, so it was a trap. Retry / Quit remain.
The bundled workerd binary (npm workerd >= 1.20240924.0) is built with minos 13.5, so it crashes at launch on older macOS with `dyld: Symbol not found: __libcpp_verbose_abort`, taking down both the control-plane and frontend workerd and leaving the app stuck at "couldn't finish starting up". No eligible workerd targets a lower OS: the last minos-11.5 build (1.20240919.0) predates our frontend's nodejs_compat_v2 compat_date floor (2024-09-23), which OpenNext requires. - Bump macOS minimumSystemVersion 13.0 -> 13.5 so macOS blocks launch on unsupported versions with a clear native dialog instead of a broken partial startup. - Download page: state "Requires macOS 13.5 or later" under the button and best-effort warn pre-13.5 visitors (Chromium UA Client Hints only; advisory, never disables the download) to save a wasted download. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014t8Ukp4NPWtqJ55X261wMZ
0.7.0 was already released, so ship the macOS 13.5 startup fix as 0.8.0. Commit the vm-image.json v2->v3 pin, which already shipped in the 0.7.0 build (sandbox-v3.img) but was never committed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014t8Ukp4NPWtqJ55X261wMZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix compatibility issues and state min osx requirement 13.5