Skip to content

feat: rule engine and smt#1066

Merged
Gbangbolaoluwagbemiga merged 1 commit into
HyperSafeD:mainfrom
Securify001:feat/sanctifier-core-rule-engine-e2e-and-smt-module-boundaries
Jun 28, 2026
Merged

feat: rule engine and smt#1066
Gbangbolaoluwagbemiga merged 1 commit into
HyperSafeD:mainfrom
Securify001:feat/sanctifier-core-rule-engine-e2e-and-smt-module-boundaries

Conversation

@Securify001

Copy link
Copy Markdown
Contributor

Summary

Hardens tooling/sanctifier-core in two areas so the project scales reliably in CI.

  • Rule engine orchestration: integration/e2e coverage Added rule_engine_orchestration_test.rs (20 tests) covering the full RuleRegistry pipeline end-to-end: registry population, per-rule firing, run_all / run_by_name consistency, determinism across repeated calls, custom regex rule execution, registry extensibility, workspace-scale multi-file scan, and RuleViolation JSON output stability. Added a dedicated rule-engine-e2e CI job in rust.yml. Also added the missing Z3 install step to the three existing jobs that lacked it.

  • Z3 backend invariants (S011): clearer module boundaries Replaced the monolithic smt.rs with a src/smt/ directory module split into four focused sub-modules (types, invariants, backend, benchmark) with a re-export facade in mod.rs zero breaking surface on all existing call sites. Added smt_module_boundaries_test.rs (21 tests) verifying each sub-module boundary independently and cross-module type flow. Added a dedicated smt-module-boundaries CI job.

DOCUMENTATION_INDEX.md updated with links to both test files, CI jobs, and the smt/ module layout table

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Maintenance or refactor

Testing

List the commands you ran and the scope of validation.

cargo fmt --all --check
cargo clippy --workspace --all-targets --all-features -- -D warnings
cargo test -p sanctifier-core --all-features
cargo test -p sanctifier-cli
cd frontend && npm test

Checklist

  • I ran the relevant tests locally, or explained why they were not needed.
  • I updated documentation for any user-facing behavior changes.
  • I added or updated tests for the change when appropriate.
  • I added a changelog or release-notes entry when needed, or confirmed none is required.
  • I verified this branch is up to date with main and merge conflicts are resolved.

Closes #495
Closes #504
Closes #506

@vercel

vercel Bot commented Jun 28, 2026

Copy link
Copy Markdown

@Securify001 is attempting to deploy a commit to the gbangbolaoluwagbemiga's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jun 28, 2026

Copy link
Copy Markdown

@Securify001 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Securify001 Securify001 force-pushed the feat/sanctifier-core-rule-engine-e2e-and-smt-module-boundaries branch from 1456509 to 580a992 Compare June 28, 2026 14:06
@Gbangbolaoluwagbemiga Gbangbolaoluwagbemiga merged commit b34eb11 into HyperSafeD:main Jun 28, 2026
9 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants