Add REST API with JAX-RS/OpenAPI annotations and endpoint tests#46
Open
stalep wants to merge 1 commit intoHyperfoil:mainfrom
Open
Add REST API with JAX-RS/OpenAPI annotations and endpoint tests#46stalep wants to merge 1 commit intoHyperfoil:mainfrom
stalep wants to merge 1 commit intoHyperfoil:mainfrom
Conversation
5 tasks
barreiro
requested changes
Apr 16, 2026
Contributor
barreiro
left a comment
barreiro
left a comment
There was a problem hiding this comment.
I think the REST endpoints should be defined in their own classes. otherwise the CLI will have to pull in all the web dependencies.
My plan was to have *Resource classes in a new package where the endpoints are defined, leaving the *ServiceInterface as normal java interfaces.
stalep
force-pushed
the
rest_ready
branch
2 times, most recently
from
c6962fb to
43e8db3
Compare
Member
Author
|
I agree with your suggestion @barreiro! I updated the pr, now I created the endpoints in separate classes in the rest folder. Can you have another look? |
Separates JAX-RS/OpenAPI annotations from service interfaces so the CLI does not pull in web dependencies. Each *ServiceInterface is now a plain Java interface; REST routing lives in *Resource classes in the new rest package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make h5m ready for a React frontend by adding REST endpoints to existing service interfaces.