Daily progress 2026-04-05: remove tracked build output, add missing tests, fix QUICKSTART API examples#90
Conversation
…analysis tests, QUICKSTART fixes, TODO update Agent-Logs-Url: https://github.com/HyperionGray/massweb/sessions/ce17c793-0a4e-4c2b-9a9b-f567b2815deb Co-authored-by: P4X-ng <223870169+P4X-ng@users.noreply.github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.
Reviewed by Cursor Bugbot for commit 96d5e3a. Configure here.
| *.log | ||
| *.log.* | ||
| *.diff | ||
| docs/_build/ |
There was a problem hiding this comment.
Duplicate .gitignore entry for docs/_build/
Low Severity
The newly added docs/_build/ on line 10 duplicates the identical entry already present on line 12. One of the two entries is redundant.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 96d5e3a. Configure here.
| def test_exactly_at_max_parse_size_not_parse_worthy(self): | ||
| resp = _make_response(content_type="text/html", | ||
| content_length=5000001) | ||
| self.assertFalse(parse_worthy(resp)) |
There was a problem hiding this comment.
Boundary test uses off-by-one content length value
Medium Severity
test_exactly_at_max_parse_size_not_parse_worthy claims to test the boundary where content_length equals max_parse_size (5000000), but actually uses content_length=5000001 — one above the boundary. The real implementation uses strict >, so a value of exactly 5000000 would actually return True (parse worthy), meaning this test doesn't exercise the boundary it claims to and would mask a real off-by-one discrepancy between the test name's intent and the implementation's behavior.
Reviewed by Cursor Bugbot for commit 96d5e3a. Configure here.
| @@ -0,0 +1,86 @@ | |||
| import unittest | |||
| from unittest.mock import MagicMock | |||
| import requests | |||
There was a problem hiding this comment.
Unused MagicMock and requests imports in test file
Low Severity
MagicMock (from unittest.mock) and requests are imported but never referenced in any test. Only Response (imported directly on line 4) and parse_worthy are actually used. The MagicMock import in particular suggests the developer may have planned mock-based tests that were never completed.
Reviewed by Cursor Bugbot for commit 96d5e3a. Configure here.


Four concrete items from the 2026-03-09 TODO backlog addressed in a single pass.
.gitignore+ build output removaldocs/_build/to.gitignoreNew unit tests for previously untested modules
test/proxy_rotator/test_proxy_rotate.py(5 tests)IndexError, statistical distribution across all proxiestest/mass_requests/test_response_analysis.py(13 tests)sys.getsizeoffallback path,TypeErroron non-ResponseinputQUICKSTART.mdAPI correctnessEvery example previously referenced non-existent classes or methods (
PayloadGenerator.from_file,FuzzyTarget(name=…, method=…),check.scan(),MassCrawl(target)). Replaced with working code against the real public API:Test commands corrected from
pytesttopython -m unittest discover test/.TODO.mdMarked completed 2026-03-09 items, added 2026-04-05 analysis, and added a FIXME inventory table tracking 12 known debt items across core modules so they are visible without a grep.
Note
Low Risk
Low risk: changes are limited to
.gitignore,TODO.md, and new unit tests covering existing helper functions without altering runtime behavior.Overview
Stops tracking generated Sphinx documentation output by adding
docs/_build/to.gitignore, and updatesTODO.mdto reflect completed cleanup/test tasks.Adds new unit tests for
massweb.mass_requests.response_analysis.parse_worthy(content-type/size gating and type validation) and formassweb.proxy_rotator.proxy_rotate.get_random_proxy(selection behavior and empty-list error case).Reviewed by Cursor Bugbot for commit 96d5e3a. Configure here.