-
Notifications
You must be signed in to change notification settings - Fork 28
Documentation link audit: fix dead/stale targets and remove duplicated README sections #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -11,7 +11,7 @@ Python wrappers for Chrome DevTools Protocol (CDP). | |||||||||||||||||||||
|
|
||||||||||||||||||||||
| overview | ||||||||||||||||||||||
| getting_started | ||||||||||||||||||||||
| connection | ||||||||||||||||||||||
| browser_control | ||||||||||||||||||||||
| api | ||||||||||||||||||||||
| develop | ||||||||||||||||||||||
| changelog | ||||||||||||||||||||||
|
|
@@ -22,9 +22,3 @@ Indices | |||||||||||||||||||||
|
|
||||||||||||||||||||||
| * :ref:`genindex` | ||||||||||||||||||||||
| * :ref:`modindex` | ||||||||||||||||||||||
|
Comment on lines
23
to
24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Hyperion Gray branding logo was removed from the documentation index page. It should be retained to maintain consistent branding for the repository's documentation.
Suggested change
|
||||||||||||||||||||||
|
|
||||||||||||||||||||||
|
|
||||||||||||||||||||||
| .. image:: https://hyperiongray.s3.amazonaws.com/define-hg.svg | ||||||||||||||||||||||
| :target: https://www.hyperiongray.com/?pk_campaign=github&pk_kwd=pycdp | ||||||||||||||||||||||
| :alt: define hyperiongray | ||||||||||||||||||||||
| :width: 400px | ||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,13 +30,9 @@ wrappers, this project makes it easier and faster to write CDP client code. | |
| this, providing Playwright-style helpers for navigation, element interaction, | ||
| screenshots, and more. See :doc:`browser_control` for details. | ||
|
|
||
| **This package provides Chrome DevTools Protocol r678025.** Download a compatible | ||
| Chrome package: | ||
|
|
||
| * `Linux <https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/678025/chrome-linux.zip>`_ | ||
| * `Mac <https://storage.googleapis.com/chromium-browser-snapshots/Mac/678025/chrome-mac.zip>`_ | ||
| * `Windows 32-bit <https://storage.googleapis.com/chromium-browser-snapshots/Win/678025/chrome-win.zip>`_ | ||
| * `Windows 64-bit <https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/678025/chrome-win.zip>`_ | ||
| **This package provides Chrome DevTools Protocol r678025.** For a current, | ||
| maintained way to download Chrome/Chromium builds, use | ||
| `Chrome for Testing <https://googlechromelabs.github.io/chrome-for-testing/>`_. | ||
|
Comment on lines
+33
to
+35
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Chrome for Testing only provides Chrome/Chromium builds starting from version 113 (released in 2023). However, this package is specified to target Chrome DevTools Protocol |
||
|
|
||
| **Install from PyPI (requires Python ≥3.8):** | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Hyperion Gray branding logo and link were removed during the cleanup of the tail sections. Since this repository is maintained under the Hyperion Gray organization, the branding logo should be retained at the end of the README.