Update the pom's Java version to match the github build.#97
Open
shawjef3 wants to merge 1 commit into
Open
Conversation
shawjef3
force-pushed
the
pom-java-version
branch
from
a1908ec to
83e0b99
Compare
yuzawa-san
reviewed
May 12, 2026
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <maven.compiler.source>1.8</maven.compiler.source> | ||
| <maven.compiler.target>1.8</maven.compiler.target> | ||
| <maven.compiler.release>21</maven.compiler.release> |
Contributor
There was a problem hiding this comment.
while i am in favor of using maven.compiler.release i'm not really following the bump to 21. i thought the baseline the library should target should be low (maybe not 1.8, but perhaps 17 as that is a reasonable baseline.) raising it too high risks dropping support for people who do not upgrade to jdk's readily (even though they should).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes local builds as described in #96.