Skip to content

Verify content rewriting pipeline is platform-agnostic (PR 8) #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prk-Jr merged 9 commits into from
Apr 15, 2026
Merged

Verify content rewriting pipeline is platform-agnostic (PR 8) #600

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ffa1174
Document content rewriting as platform-agnostic in platform module
prk-Jr Mar 31, 2026
fbbf767
Document html_processor as platform-agnostic
prk-Jr Mar 31, 2026
b89a9e6
Document streaming_processor as platform-agnostic
prk-Jr Mar 31, 2026
6fa8b38
Fix unresolved doc link: replace EdgeRequest with edgezero_core::http…
prk-Jr Mar 31, 2026
e9ce63d
Add plan for content rewriting
prk-Jr Mar 31, 2026
34c44bd
Merge branch 'feature/edgezero-pr7-geo-client-info' into feature/edge…
prk-Jr Apr 1, 2026
2333227
Address PR review feedback for rewriting pipeline docs
prk-Jr Apr 6, 2026
69c49af
Address review findings
prk-Jr Apr 10, 2026
08803e0
Resolve review findings
prk-Jr Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/trusted-server-adapter-fastly/src/platform.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ impl PlatformBackend for FastlyPlatformBackend {
// FastlyPlatformHttpClient — helpers
// ---------------------------------------------------------------------------

/// Convert a platform-neutral [`EdgeRequest`] to a [`fastly::Request`].
/// Convert a platform-neutral [`edgezero_core::http::Request`] to a [`fastly::Request`].
///
/// Only `Body::Once` bodies are forwarded; `Body::Stream` bodies are not
/// used on this path (proxy.rs builds bodies from byte slices).
Expand Down
18 changes: 16 additions & 2 deletions crates/trusted-server-core/src/html_processor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,20 @@
//! Simplified HTML processor that combines URL replacement and integration injection
//! Simplified HTML processor that combines URL replacement and integration injection.
//!
//! This module provides a `StreamProcessor` implementation for HTML content.
//! This module provides a [`StreamProcessor`] implementation for HTML content.
//! It handles `<script>` tag injection at `<head>`, attribute URL rewriting
//! (`href`, `src`, `action`, `srcset`, `imagesrcset`), and post-processing
//! hooks for enabled integrations.
//!
//! # Platform notes
//!
//! This module is **platform-agnostic** (verified in PR 8). It has zero
//! `fastly` imports and depends only on `lol_html`, `std`, and crate-internal
//! types. [`create_html_processor`] returns an `impl `[`StreamProcessor`]
//! whose `process_chunk` method operates on `&[u8]` slices with no
//! platform body type involved.
//!
//! Future adapters (PR 16/17) do not need to implement any content-rewriting
//! interface. See `crate::platform` module doc for the authoritative note.
use std::cell::Cell;
use std::io;
use std::rc::Rc;
Expand Down
24 changes: 24 additions & 0 deletions crates/trusted-server-core/src/platform/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,30 @@
//! - [`PlatformBackend`] — dynamic backend registration
//! - [`PlatformHttpClient`] — outbound HTTP client
//! - [`PlatformGeo`] — geographic information lookup
//!
//! ## Platform-Agnostic Components
//!
//! The following components were evaluated for platform-specific behavior
//! (PR 8) and found to have a platform-agnostic rewriting pipeline. No
//! platform trait is required; future adapters (PR 16/17) need not provide
//! any content-rewriting implementation:
//!
//! - **Content rewriting** — `html_processor`, `streaming_processor`,
//! `streaming_replacer`, and `rsc_flight` modules use only standard Rust
//! (`std::io::Read`/`Write`, `lol_html`, `flate2`, `brotli`). The pipeline
//! is accessed via `StreamingPipeline::process<R: Read, W: Write>` which
//! accepts any reader, including `fastly::Body` (which implements
//! `std::io::Read`).
//!
//! The `publisher.rs` handler module is platform-coupled at its handler
//! layer — it accepts and returns `fastly::Body` in function signatures
//! such as `process_response_streaming`. This is an HTTP-type coupling
//! that will be addressed in Phase 2 (PR 11) alongside all other
//! `fastly::Request`/`Response`/`Body` migrations. It is not a
//! content-rewriting concern.
//!
//! No `PlatformContentRewriter` trait exists or is needed.
//!

mod error;
mod http;
Expand Down
12 changes: 12 additions & 0 deletions crates/trusted-server-core/src/streaming_processor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,18 @@
//! - Pluggable content processors (text replacement, HTML rewriting, etc.)
//! - Memory-efficient streaming
//! - UTF-8 boundary handling
//!
//! # Platform notes
//!
//! This module is **platform-agnostic** (verified in PR 8). It has zero
Comment thread
prk-Jr marked this conversation as resolved.
Outdated
//! `fastly` imports. [`StreamingPipeline::process`] is generic over
//! `R: Read + W: Write` — any reader or writer works, including
//! `fastly::Body` (which implements `std::io::Read`) or standard
//! `std::io::Cursor<&[u8]>`.
//!
//! Future adapters (PR 16/17) do not need to implement any compression or
//! streaming interface. See `crate::platform` module doc for the
//! authoritative note.

use error_stack::{Report, ResultExt};
use std::io::{self, Read, Write};
Expand Down
Loading
Loading