Remove unused dependencies and disable unnecessary test targets#615
Merged
Remove unused dependencies and disable unnecessary test targets#615
Conversation
Drop handlebars, pin-project-lite, tokio-test, tokio-stream from the workspace. Remove log-fastly from trusted-server-core, and serde, serde_json, trusted-server-js from the Fastly adapter. Promote trusted-server-core to a workspace dependency. Disable doctests on trusted-server-js and trusted-server-openrtb crates, and disable the test target on trusted-server-js since it has no Rust tests.
ChristianPavilonis
approved these changes
Apr 7, 2026
Collaborator
ChristianPavilonis
left a comment
ChristianPavilonis
left a comment
There was a problem hiding this comment.
👍 looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #614
Summary
handlebars,pin-project-lite,tokio-test,tokio-streamlog-fastlyfrom trusted-server-core (only needed in the Fastly adapter)serde,serde_json,trusted-server-jsfrom Fastly adapter (accessed transitively via trusted-server-core)trusted-server-coreto a workspace dependencydocteston trusted-server-js and trusted-server-openrtb; disableteston trusted-server-jsTest plan
cargo check --workspacepassescargo test --workspacepassescargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1succeeds