Migrate handler layer to HTTP types (PR 12) by prk-Jr · Pull Request #624 · IABTechLab/trusted-server

prk-Jr · 2026-04-08T15:07:08Z

Summary

Move the PR 12 handler boundary to http request/response types so core handlers no longer depend on Fastly request/response APIs.
Keep Fastly isolated to the adapter entry/exit path and the still-unmigrated integration/provider boundary, which keeps PR 13 scope separate.
Lock the migrated surface with tests and migration guards so later changes do not accidentally reintroduce handler-layer Fastly types.

Changes

File	Change
`crates/trusted-server-adapter-fastly/src/main.rs`	Move the conversion boundary to the adapter entry/exit path and route core handlers with HTTP-native requests and responses.
`crates/trusted-server-core/src/auction/endpoints.rs`	Migrate the `/auction` handler to `http` types and rebuild a Fastly request only at the provider-facing `AuctionContext` boundary.
`crates/trusted-server-core/src/auction/formats.rs`	Consume HTTP requests directly and return HTTP auction responses.
`crates/trusted-server-core/src/auction/orchestrator.rs`	Keep provider parsing Fastly-based while making the provider response conversion explicit in the orchestrator.
`crates/trusted-server-core/src/compat.rs`	Add the minimal borrowed HTTP-to-Fastly request bridge needed for the remaining provider boundary.
`crates/trusted-server-core/src/geo.rs`	Make response header injection operate on HTTP responses.
`crates/trusted-server-core/src/integrations/google_tag_manager.rs`	Adapt the integration boundary so the shared proxy helper can stay HTTP-native while the integration trait remains Fastly-based.
`crates/trusted-server-core/src/integrations/gpt.rs`	Adapt the integration boundary so the shared proxy helper can stay HTTP-native while the integration trait remains Fastly-based.
`crates/trusted-server-core/src/integrations/testlight.rs`	Adapt the integration boundary so the shared proxy helper can stay HTTP-native while the integration trait remains Fastly-based.
`crates/trusted-server-core/src/migration_guards.rs`	Extend the guard to cover the handler modules migrated in PR 12.
`crates/trusted-server-core/src/proxy.rs`	Migrate first-party proxy/click/sign/rebuild handlers and response rewriting to HTTP request/response types.
`crates/trusted-server-core/src/publisher.rs`	Migrate publisher handlers to HTTP types and use the platform HTTP client for publisher-origin fetches.
`crates/trusted-server-core/src/request_signing/endpoints.rs`	Migrate request-signing and admin handlers to HTTP request/response types.

Closes

Closes #493

Test plan

cargo test --workspace
cargo clippy --workspace --all-targets --all-features -- -D warnings
cargo fmt --all -- --check
JS tests: cd crates/js/lib && npx vitest run (not run; no JS/TS files changed)
JS format: cd crates/js/lib && npm run format
Docs format: cd docs && npm run format
WASM build: cargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1
Manual testing via fastly compute serve
Other: verified remaining Fastly usage is limited to the adapter boundary and the still-unmigrated integration/provider boundary

Checklist

Changes follow CLAUDE.md conventions
No unwrap() in production code — use expect("should ...")
Uses tracing macros (not println!)
New code has tests
No secrets or credentials committed

ChristianPavilonis

Summary

Clean migration of the handler layer from fastly::Request/fastly::Response to http::Request<EdgeBody>/http::Response<EdgeBody>. The conversion boundary is pushed to the adapter entry/exit and the still-unmigrated integration trait boundary. Well-tested, CI passes.

Non-blocking

♻️ refactor

Duplicate error-to-response functions: http_error_response (new, returns HttpResponse) and to_error_response (existing, returns FastlyResponse) implement identical logic with different return types. Expected migration scaffolding — track for cleanup in PR 15 when Fastly types are fully removed. (main.rs:255-267 / error.rs:10)

CI Status

integration tests: PASS
browser integration tests: PASS
prepare integration artifacts: PASS

ChristianPavilonis · 2026-04-09T15:22:43Z

crates/trusted-server-adapter-fastly/src/main.rs


    // Match known routes and handle them
-    let result = match (method, path.as_str()) {
+    match (method.clone(), path.as_str()) {


🌱 seedling — method is already an owned value (cloned on line 138). Since it's not used after the match, this .clone() is redundant — it could be moved instead:

match (method, path.as_str()) {

ChristianPavilonis · 2026-04-09T15:22:43Z

crates/trusted-server-core/src/publisher.rs

 /// - The proxy request fails
 /// - The origin backend is unreachable
-pub fn handle_publisher_request(
+pub async fn handle_publisher_request(


🤔 thinking — This changed from sync to async since it now calls services.http_client().send().await instead of the Fastly SDK's synchronous req.send(). The caller wraps everything in block_on(route_request(...)), so it should be behaviorally equivalent — just confirming req.send() was previously a blocking call on the Fastly runtime.

ChristianPavilonis · 2026-04-09T15:22:43Z

crates/trusted-server-core/src/auction/formats.rs

+    Ok(response)
+}
+
+fn insert_response_header(


🏕 camp site — insert_response_header takes name: &'static str and relies on implicit conversion. Taking http::HeaderName directly as the parameter type would make the API clearer and avoid runtime parsing. Since callers pass known-valid string literals this works fine — just a minor improvement opportunity.

aram356

Summary

Solid mechanical migration of the handler layer from Fastly request/response types to http crate types. The conversion boundary is cleanly pushed to the adapter entry point, with proper compat shims for the still-unmigrated integration/provider boundary.

Non-blocking

🤔 thinking

platform_response_to_fastly duplicated into orchestrator.rs: Copy-pasted from proxy.rs rather than shared via compat.rs. Two separate HTTP→Fastly response paths risk divergence (this copy uses set_header which drops multi-value headers; compat::to_fastly_response doesn't). (orchestrator.rs:15)
sync→async handle_publisher_request: Public API signature change — only caller uses block_on so it works, but worth documenting. (publisher.rs:305)

♻️ refactor

Cursor::new(body.into_bytes()) repeated 4 times: Could extract a small body_as_reader helper to centralize body materialization. (proxy.rs:175, publisher.rs:228,246,263)

🌱 seedling

DEFAULT_PUBLISHER_FIRST_BYTE_TIMEOUT hardcoded at 15s: Good to make it explicit, but may need to be configurable per deployment. (publisher.rs:22)

📝 note

Integration proxy double-conversion: GTM, GPT, testlight each wrap proxy_request with from_fastly_request/to_fastly_response, copying bodies twice. Expected for the PR 13 boundary.

⛏ nitpick

Inconsistent test type alias style: proxy.rs tests use HttpMethod/HttpStatusCode prefixes; publisher.rs tests don't. The unprefixed style is cleaner.

CI Status

integration tests: PASS
browser integration tests: PASS
prepare integration artifacts: PASS

aram356 · 2026-04-10T05:41:02Z

crates/trusted-server-core/src/auction/orchestrator.rs

 use super::provider::AuctionProvider;
 use super::types::{AuctionContext, AuctionRequest, AuctionResponse, Bid, BidStatus};

+fn platform_response_to_fastly(


🤔 thinking — platform_response_to_fastly duplicated from proxy.rs

This is a copy of the function that was removed from proxy.rs. Meanwhile the integration shims (GTM, GPT, testlight) go through compat::to_fastly_response for the same purpose. Two separate HTTP→Fastly response conversion paths makes divergence easy — e.g., this copy uses set_header (replaces duplicate header names) while compat::to_fastly_response preserves them.

Consider moving this into compat.rs as a shared helper, or at minimum cross-referencing the two so PR 15 removes both.

aram356 · 2026-04-10T05:41:02Z

crates/trusted-server-core/src/auction/orchestrator.rs

+    };
+    let mut resp = fastly::Response::from_status(parts.status.as_u16());
+    for (name, value) in parts.headers.iter() {
+        resp.set_header(name.as_str(), value.as_bytes());


🤔 thinking — set_header drops multi-value headers

resp.set_header(name, value) in a loop replaces per header name. If a provider response carries multi-value headers (e.g. Set-Cookie), only the last value survives. The analogous code in rebuild_response_with_body (proxy.rs) was correctly changed to append.

Low risk since this is a PR 15 removal target and auction provider responses are unlikely to have meaningful duplicates, but worth keeping in mind.

aram356 · 2026-04-10T05:41:02Z

crates/trusted-server-core/src/proxy.rs

    let mut pipeline = StreamingPipeline::new(config, processor);
    pipeline
-        .process(body, &mut output)
+        .process(Cursor::new(body.into_bytes()), &mut output)


♻️ refactor — Cursor::new(body.into_bytes()) pattern appears 4 times

This same pattern shows up here, and 3 times in publisher.rs (process_response_streaming). A small helper would reduce repetition and centralize the implicit body-materialization:

fn body_as_reader(body: EdgeBody) -> Cursor<bytes::Bytes> { Cursor::new(body.into_bytes()) }

aram356 · 2026-04-10T05:41:02Z

crates/trusted-server-core/src/publisher.rs

 use crate::synthetic::{get_or_generate_synthetic_id, is_valid_synthetic_id};

 const SUPPORTED_ENCODING_VALUES: [&str; 3] = ["gzip", "deflate", "br"];
+const DEFAULT_PUBLISHER_FIRST_BYTE_TIMEOUT: Duration = Duration::from_secs(15);


🌱 seedling — Hardcoded 15s timeout

The old BackendConfig::from_url() had its own default; this makes it explicit which is good. But 15 seconds may not be right for all deployments. Worth considering making this configurable via settings.publisher in a follow-up.

aram356 · 2026-04-10T05:41:02Z

crates/trusted-server-core/src/publisher.rs

 /// - The proxy request fails
 /// - The origin backend is unreachable
-pub fn handle_publisher_request(
+pub async fn handle_publisher_request(


📝 note — sync → async signature change

This went from pub fn to pub async fn because it now uses services.http_client().send(...).await instead of Fastly's blocking req.send(). The only caller already wraps in block_on so it works. Just flagging as a public API change.

aram356 · 2026-04-10T05:41:02Z

crates/trusted-server-core/src/proxy.rs

-    use fastly::http::{header, HeaderValue, Method, StatusCode};
-    use fastly::{Request, Response};
+    use http::{
+        header, HeaderValue, Method as HttpMethod, Request as HttpRequest,


⛏ nitpick — Prefixed type aliases

HttpMethod, HttpRequest, HttpResponse, HttpStatusCode — the Http prefix doesn't add clarity inside a test module that already imports from the http crate. The publisher.rs tests use the unprefixed names (Method, Request as HttpRequest, StatusCode) which reads more naturally.

aram356 · 2026-04-10T05:41:03Z

crates/trusted-server-core/src/integrations/google_tag_manager.rs

        };

-        let mut response = proxy_request(settings, req, proxy_config, services)
+        let mut response = compat::to_fastly_response(


📝 note — Double-conversion at integration boundary

Fastly Request → HTTP Request → proxy_request → HTTP Response → Fastly Response. This copies the request and response bodies twice. Same pattern in gpt.rs and testlight.rs. Understood this is intentional (integration trait stays Fastly-based until PR 13), just documenting the cost.

Migrate handler layer to HTTP types

a9dd665

prk-Jr self-assigned this Apr 8, 2026

prk-Jr changed the title ~~(PR 12) Migrate handler layer to HTTP types~~ Migrate handler layer to HTTP types (PR 12) Apr 8, 2026

prk-Jr linked an issue Apr 8, 2026 that may be closed by this pull request

Handler layer type migration #493

Open

prk-Jr requested review from ChristianPavilonis and aram356 April 9, 2026 08:36

prk-Jr linked an issue Apr 9, 2026 that may be closed by this pull request

Thread RuntimeServices into integration and provider entry points #515

Open

ChristianPavilonis approved these changes Apr 9, 2026

View reviewed changes

aram356 requested changes Apr 10, 2026

View reviewed changes

prk-Jr added 2 commits April 10, 2026 13:40

Address review findings

ba9c608

Removed unused import

4cd511c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate handler layer to HTTP types (PR 12)#624

Migrate handler layer to HTTP types (PR 12)#624
prk-Jr wants to merge 3 commits intofeature/edgezero-pr11-utility-layer-migration-v2from
feature/edgezero-pr12-handler-layer-types

prk-Jr commented Apr 8, 2026

Uh oh!

ChristianPavilonis left a comment

Uh oh!

ChristianPavilonis Apr 9, 2026

Uh oh!

ChristianPavilonis Apr 9, 2026

Uh oh!

ChristianPavilonis Apr 9, 2026

Uh oh!

aram356 left a comment

Uh oh!

aram356 Apr 10, 2026

Uh oh!

aram356 Apr 10, 2026

Uh oh!

aram356 Apr 10, 2026

Uh oh!

aram356 Apr 10, 2026

Uh oh!

aram356 Apr 10, 2026

Uh oh!

aram356 Apr 10, 2026

Uh oh!

aram356 Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

prk-Jr commented Apr 8, 2026

Summary

Changes

Closes

Test plan

Checklist

Uh oh!

ChristianPavilonis left a comment

Choose a reason for hiding this comment

Summary

Non-blocking

♻️ refactor

CI Status

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aram356 left a comment

Choose a reason for hiding this comment

Summary

Non-blocking

🤔 thinking

♻️ refactor

🌱 seedling

📝 note

⛏ nitpick

CI Status

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants