Skip to content

Use binding namespace credentials for cloud API calls - #284

Merged
bevicted merged 1 commit into
masterfrom
bevicted/apikey
Sep 3, 2026
Merged

bevicted merged 1 commit into
masterfrom
bevicted/apikey

Conversation

@bevicted

@bevicted bevicted commented Sep 3, 2026

Copy link
Copy Markdown
Contributor
  1. This fixes use of the victim namespace's cloud credential, but it does not prevent the controller from reading the cross-namespace Service CR. Some metadata may still be exposed. Fully blocking cross-namespace access would require validation or authorization around serviceNamespace.
  2. Credential lookup retains the documented fallback behavior: management-namespace credentials, or the default namespace credential when no local credential exists. If "same namespace" must be enforced literally with no fallback, this patch is insufficient. Based on the existing account-context documentation, the intended rule appears to be "resolve credentials using the Binding namespace", including those fallbacks.

Test guards against regression.

@bevicted
bevicted enabled auto-merge (squash) September 3, 2026 09:03
Signed-off-by: bevicted <170766675+bevicted@users.noreply.github.com>
@bevicted
bevicted merged commit 403f22d into master Sep 3, 2026
2 checks passed
@bevicted
bevicted deleted the bevicted/apikey branch September 3, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants