feat(logpush): regenerate SDK and add comprehensive integration tests#318
Open
anaghajoshiibm wants to merge 1 commit into
Open
feat(logpush): regenerate SDK and add comprehensive integration tests#318anaghajoshiibm wants to merge 1 commit into
anaghajoshiibm wants to merge 1 commit into
Conversation
Signed-off-by: Anagha Joshi <Anagha.Joshi3@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Fixes "unexpected EOF" error when retrieving logpush jobs configured with custom HTTP destinations. Optional fields in
LogpushJobPackstruct had incorrectvalidate:"required"tags, causing unmarshaling to fail when API returned null values.Fixes: https://github.ibm.com/NetworkTribe/CIS_Support/issues/5296
PR Checklist
Please make sure that your PR fulfills the following requirements:
PR Type
What is the current behavior?
SDK fails to parse API responses for logpush jobs with custom HTTP destinations when optional fields (
last_complete,last_error,error_message) contain null values. Error: "unexpected EOF" with HTTP 200 status code.What is the new behavior?
SDK correctly handles null values in optional fields. Logpush jobs with custom HTTP destinations can be retrieved without errors. Fields are properly marked as optional with
omitemptyJSON tags instead ofvalidate:"required".Does this PR introduce a breaking change?
Other information