[FEATURE] Init/ErrorHandling: Unify handling of logging errors to log files#11658
Open
mjansenDatabay wants to merge 12 commits into
Open
Conversation
…application ports
…ing` in `DelegatingHandler`
… incident reporting
mjansenDatabay
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, only the production default error handler wrote uncaught exceptions to ILIAS’ dedicated error log folder. SOAP and other Whoops handlers did not — and the log file logic lived inside
defaultHandler()together with building the user message.This change pulls log file reporting out of the response handler and runs it as its own step in the Whoops chain. Every handled exception can be written (with this PR, this is only added to the SOAP handler) to the configured log folder, and the identifier shown to the user is the same one used for the log file name.
In a Nutshell:
components/ILIAS/Init/src.RecordErrorIncidentHandler(logging to a dedicated log file) → Logging (to ILIAS log file, if defined byRuntime) →DelegatingHandler(context-specific response)These changes don't use the new integration mechanisms, yet. They just address a ROADMAP topic. Nevertheless, I guess migrating the integration could be easier in future due to the new clean classes.