Skip to content

GLOWS - bugfix#3015

Draft
laspsandoval wants to merge 2 commits intoIMAP-Science-Operations-Center:devfrom
laspsandoval:glows_bugfix
Draft

GLOWS - bugfix#3015
laspsandoval wants to merge 2 commits intoIMAP-Science-Operations-Center:devfrom
laspsandoval:glows_bugfix

Conversation

@laspsandoval
Copy link
Copy Markdown
Contributor

This pull request improves the robustness of the GLOWS L1A data processing pipeline and enhances test coverage, particularly for handling packets with missing or insufficient direct event data. The changes include stricter filtering of incomplete records, improved logging and debugging output, the addition of new test data and fixtures, and a new test case for empty direct event packets.

Improvements to GLOWS L1A data handling:

  • The filter for DE records now excludes records with empty direct_events lists, not just None, ensuring only complete records are processed.
  • In _generate_direct_events, added a check for insufficient direct event data (<8 bytes), with logging and early return to prevent errors and aid debugging.

Test data and coverage enhancements:

  • Added a new test data file (imap_glows_l0_raw_20260202-repoint00145_v001.pkts) to the external test data configuration for more comprehensive validation.
  • Introduced a new pytest fixture repoint_packet_path to provide access to the new test data file.
  • Added a test case test_glows_l1a_empty_de_packet to verify that L1A processing correctly handles packets with no direct event data.

@laspsandoval laspsandoval self-assigned this Apr 15, 2026
@laspsandoval laspsandoval added the bug Something isn't working label Apr 15, 2026
@laspsandoval laspsandoval requested review from maxinelasp and tech3371 and removed request for tech3371 April 15, 2026 20:44
@laspsandoval laspsandoval linked an issue Apr 15, 2026 that may be closed by this pull request
@laspsandoval laspsandoval marked this pull request as draft April 15, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

BUG - GLOWS L1a: some CDFs missing in IMAP data repository

1 participant