GLOWS - bugfix#3015
Draft
laspsandoval wants to merge 2 commits intoIMAP-Science-Operations-Center:devfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness of the GLOWS L1A data processing pipeline and enhances test coverage, particularly for handling packets with missing or insufficient direct event data. The changes include stricter filtering of incomplete records, improved logging and debugging output, the addition of new test data and fixtures, and a new test case for empty direct event packets.
Improvements to GLOWS L1A data handling:
direct_eventslists, not justNone, ensuring only complete records are processed._generate_direct_events, added a check for insufficient direct event data (<8 bytes), with logging and early return to prevent errors and aid debugging.Test data and coverage enhancements:
imap_glows_l0_raw_20260202-repoint00145_v001.pkts) to the external test data configuration for more comprehensive validation.repoint_packet_pathto provide access to the new test data file.test_glows_l1a_empty_de_packetto verify that L1A processing correctly handles packets with no direct event data.