Hi: dep updates and improvments#1237
Merged
tech3371 merged 3 commits intoIMAP-Science-Operations-Center:devfrom Apr 14, 2026
Merged
Hi: dep updates and improvments#1237tech3371 merged 3 commits intoIMAP-Science-Operations-Center:devfrom
tech3371 merged 3 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
tmplummer
approved these changes
Apr 13, 2026
Contributor
tmplummer
left a comment
tmplummer
left a comment
There was a problem hiding this comment.
I think this looks good. I am having a little trouble joining the spice inheritance. My suggestion would be only to make a spice_basic common dependency that goes across levels/products.
Contributor
Author
Totally. I will check that dependency is correct for the time being and if you show an example of what you are looking for, we all can follow that as example. |
Contributor
Author
|
@tmplummer I merged Hi's dependency. Can you open PR with your idea of inheritance? I like to see and know and use for others in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
related to #1153
Overview
Double checking and correction based on latest dependency csv file in dev.
File changes
Testing