Try to avoid race condition on startup#88
Open
FreddieAkeroyd wants to merge 1 commit into
Open
Conversation
FreddieAkeroyd
force-pushed
the
pwrdet_race_condition
branch
from
f995877 to
8200d1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try and avoid what looks like a race condition on startup - previously it would try and change the number quite soon after ioc start, change this so it does it after its usual periodic period, but now also stop the repeated resets as they are not needed. Also add an
SDISto read so it doesn't queue at same time as a write, but chance of that causing an issue were quite small.There is still a small window of an issue - currently it autosaves as if it were a position, so within 5 seconds of a change. So there is a 5 second window when it does that one and only change that if the ioc were to restart it would flag an error. We could change to an autosave triggered set if we feel this is an issue.
Will need apply to new galil driver too, will do that post review