Skip to content

[PW_SID:1099573] main: make developer mode more configurable#499

Open
IWDTestBot wants to merge 1 commit into
workflowfrom
1099573
Open

[PW_SID:1099573] main: make developer mode more configurable#499
IWDTestBot wants to merge 1 commit into
workflowfrom
1099573

Conversation

@IWDTestBot
Copy link
Copy Markdown
Owner

The developer mode (-E) option is used only for the autotest
framework to start up IWD in a state where:

  • Autoconnect is disabled
  • The station debug interface is available

For testing and development on real systems the debug interface
is convenient to have available, the trouble is starting IWD in
this mode loses the autoconnect functionality (unless you manually
enable after starting).

This patch aims to allow developer mode + autoconnect but making
allowing the -E flag to take several options:

-E (no args) - same behavior, debug interface + no autoconnect
-Etest - same as -E with no args
-Edebug - debug interface with autoconnect enabled

src/iwd.h | 7 ++++++-
src/main.c | 48 ++++++++++++++++++++++++++++++++++++++++++------
src/station.c | 16 +++++++++-------
3 files changed, 57 insertions(+), 14 deletions(-)

The developer mode (-E) option is used only for the autotest
framework to start up IWD in a state where:
 - Autoconnect is disabled
 - The station debug interface is available

For testing and development on real systems the debug interface
is convenient to have available, the trouble is starting IWD in
this mode loses the autoconnect functionality (unless you manually
enable after starting).

This patch aims to allow developer mode + autoconnect but making
allowing the -E flag to take several options:

-E (no args) - same behavior, debug interface + no autoconnect
-Etest	     - same as -E with no args
-Edebug      - debug interface with autoconnect enabled
@IWDTestBot
Copy link
Copy Markdown
Owner Author

Fetch PR
Test ID: fetch
Desc: Fetch the PR commits for this CI run
Duration: 3.38 seconds
Result: PASS

Prep - Setup ELL
Test ID: setupell
Desc: Clone, build, and install ELL
Duration: 26.10 seconds
Result: PASS

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 23.50 seconds
Result: FAIL

Output:

In file included from ../../src/common.c:31:
../../src/iwd.h:49:1: error: unknown type name 'uint32_t'
   49 | uint32_t iwd_get_developer_modes(void);
      | ^~~~~~~~
../../src/iwd.h:1:1: note: 'uint32_t' is defined in header '<stdint.h>'; did you forget to '#include <stdint.h>'?
  +++ |+#include <stdint.h>
    1 | /*
make[2]: *** [Makefile:2663: src/common.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:1800: all] Error 2
make: *** [Makefile:3461: distcheck] Error 1

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 10.72 seconds
Result: PASS

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 0.00 seconds
Result: SKIP

Output:

makecheck was skipped

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 13.22 seconds
Result: FAIL

Output:

In file included from src/common.c:31:
./src/iwd.h:49:1: error: unknown type name 'uint32_t'
   49 | uint32_t iwd_get_developer_modes(void);
      | ^~~~~~~~
./src/iwd.h:1:1: note: 'uint32_t' is defined in header '<stdint.h>'; did you forget to '#include <stdint.h>'?
  +++ |+#include <stdint.h>
    1 | /*
make[1]: *** [Makefile:2663: src/common.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1800: all] Error 2

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 0.40 seconds
Result: PASS

@IWDTestBot
Copy link
Copy Markdown
Owner Author

Fetch PR
Test ID: fetch
Desc: Fetch the PR commits for this CI run
Duration: 2.56 seconds
Result: PASS

GitLint
Test ID: gitlint
Desc: Run gitlint with rule in .gitlint
Duration: 0.53 seconds
Result: FAIL

Output:

main: make developer mode more configurable
17: B3 Line contains hard tab characters (\t): "-Etest	     - same as -E with no args"

Prep - Setup ELL
Test ID: setupell
Desc: Clone, build, and install ELL
Duration: 29.18 seconds
Result: PASS

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 17.75 seconds
Result: FAIL

Output:

In file included from ../../src/common.c:31:
../../src/iwd.h:49:1: error: unknown type name ‘uint32_t’
   49 | uint32_t iwd_get_developer_modes(void);
      | ^~~~~~~~
../../src/iwd.h:1:1: note: ‘uint32_t’ is defined in header ‘<stdint.h>’; did you forget to ‘#include <stdint.h>’?
  +++ |+#include <stdint.h>
    1 | /*
make[2]: *** [Makefile:2662: src/common.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:1799: all] Error 2
make: *** [Makefile:3460: distcheck] Error 1

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 21.35 seconds
Result: PASS

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 0.00 seconds
Result: SKIP

Output:

makecheck was skipped

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 24.85 seconds
Result: FAIL

Output:

In file included from src/common.c:31:
./src/iwd.h:49:1: error: unknown type name ‘uint32_t’
   49 | uint32_t iwd_get_developer_modes(void);
      | ^~~~~~~~
./src/iwd.h:1:1: note: ‘uint32_t’ is defined in header ‘<stdint.h>’; did you forget to ‘#include <stdint.h>’?
  +++ |+#include <stdint.h>
    1 | /*
make[1]: *** [Makefile:2662: src/common.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1799: all] Error 2

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 0.61 seconds
Result: PASS

Autotest Runner
Test ID: testrunner
Desc: Runs IWD's autotest framework
Duration: 0.00 seconds
Result: SKIP

Output:

testrunner was skipped

Clang Build
Test ID: clang
Desc: Build IWD using clang compiler
Duration: 30.30 seconds
Result: FAIL

Output:

In file included from src/common.c:31:
./src/iwd.h:49:1: error: unknown type name 'uint32_t'
uint32_t iwd_get_developer_modes(void);
^
1 error generated.
make[1]: *** [Makefile:2662: src/common.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1799: all] Error 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants