Track muted state on incidents#431
Draft
Jan-Schuppik wants to merge 2 commits into
Draft
Conversation
Move mute_reason from the object table to the incident table so each incident independently owns its mute flag. This removes Object.IsMuted(), RestoreMutedObjects(), and the transient isMuted bool — MuteReason.Valid now serves as the canonical mute flag, persisted in the same DB transaction as the history entry. Schema migrations transfer active mute state from objects to their open incidents.
Add makeIncidentFromEvent helper that drives the real ProcessEvent path to create incidents with optional mute state. Add a WithMutedIncidents sub-test that asserts mute_reason is correctly persisted and restored.
0cf7d77 to
269346c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the mute state (mute_reason) was stored on the object table, meaning all incidents for an object shared a single mute flag. This PR moves mute_reason onto the incident table so each incident independently owns its mute state.
daemon reload
Resolves: