Fix tactical overview export#1370
Merged
Merged
Conversation
Contributor
sukhwinder33445
left a comment
sukhwinder33445
left a comment
There was a problem hiding this comment.
Works fine.
TacticalStateSummary: Please remove unused imports and add return types to the methods.
nilmerg
force-pushed
the
fix/tactical-overview-export-1334
branch
from
6095c45 to
154c8d3
Compare
Member
Author
Didn't add one to |
sukhwinder33445
approved these changes
May 22, 2026
This ensures that exports to CSV/JSON contain results for both host and service states as the default export procedure only evaluates a single query. fixes #1334
nilmerg
force-pushed
the
fix/tactical-overview-export-1334
branch
from
154c8d3 to
df1d2c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a new model
TacticalStateSummarythat represents a union ofHoststateSummaryandServicestateSummary. The union of both is required to have the default export functionality also yield results for both types of states as it only evaluates the first query. Now, CSV/JSON exports also contain service states. Both can be differentiated either by looking at the column data types (nullforhosts_*columns means it's a service state summary) or by simply checking thetypecolumn which is either'host_state'or'service_state'.fixes #1334