QueryColumnsProvider: Fully use up limit with custom variables#1377
Merged
nilmerg merged 1 commit intoMay 27, 2026
Merged
Conversation
sukhwinder33445
force-pushed
the
update-notifications-hook
branch
from
fbe92e8 to
4cc6a93
Compare
Previously custom variables that didn't match any of the desired sources were eating up the query's limit and so there is a chance that not even a single variable was listed. This especially occurs with the updated notifications integration, as the available database columns are very limited in number. But even in other views this may have been noticed by users in case they have many variables that are similarly named but have no overlap with database columns. (i.e. input that doesn't match any database columns but many vars)
nilmerg
force-pushed
the
fix/query-columns-provider-does-not-show-variables-up-to-the-limit
branch
from
c890693 to
5ea0724
Compare
Member
Author
|
Tested myself with MySQL and PostgreSQL. |
sukhwinder33445
approved these changes
May 27, 2026
Contributor
sukhwinder33445
left a comment
sukhwinder33445
left a comment
There was a problem hiding this comment.
Works fine, tested on MySQL and PostgreSQL.
nilmerg
deleted the
fix/query-columns-provider-does-not-show-variables-up-to-the-limit
branch
github-project-automation
Bot
moved this from In progress
to Done
in Icinga Notifications 1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously custom variables that didn't match any of the desired sources were eating up the query's limit and so there is a chance that not even a single variable was listed. This especially occurs with the updated notifications integration, as the available database columns are very limited in number. But even in other views this may have been noticed by users in case they have many variables that are similarly named but have no overlap with database columns. (i.e. input that doesn't match any database columns but many vars)