Handle search suggestions errors#383
Merged
Merged
Conversation
It's not exception nowadays that suggestion providers are lazy evaluated and hence errors happen at a later stage than before.
It's no exception nowadays that suggestion providers are lazy evaluated and hence errors happen at a later stage than before. Additionally, a setter is introduced to indicate a failure prior assembly.
In case a failure message is set prior assembly, there's no need to pass a provider so it defaults to an empty array now.
BastianLedererIcinga
approved these changes
May 21, 2026
Contributor
BastianLedererIcinga
left a comment
BastianLedererIcinga
left a comment
There was a problem hiding this comment.
Looks good, I made some local modifications to icingadb-web's QueryColumnsProvider and my notifications-web PR to test the exception handling for both suggestion types.
I will adjust the latter to rely on these changes.
nilmerg
added a commit
to Icinga/icinga-notifications-web
that referenced
this pull request
May 22, 2026
resolve #466 Introduce `RuleSerializer` to create Json from a configured filter. Introduce `Icinga\Module\Notifications\Hook\V2` which no longer requires `serializeRuleFilter()` and `getRuleFilterTargets()` as they are now obsolete. Adjust `EventRuleController` to skip target selection use the new `RuleSerializer`. require Icinga/ipl-web#380 require Icinga/ipl-web#383 require Icinga/ipl-stdlib#75 require Icinga/ipl-stdlib#76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\ipl\Web\Control\SearchBar\Suggestionsnow catch\ipl\Web\Control\SearchBar\SearchExceptionduring assembly. Also, an unused CSS classhas-moreis not added anymore, as the initially planned pagination was never implemented and the refactor now made it unworthy to keep.\ipl\Web\FormElement\SearchSuggestions's constructor argument is now optional and a setter to show a failure message is added. In addition to that, it catches\Exceptionduring assembly and uses it to indicate a failure on its own.