Show no placeholders if a SearchEditor has no suggestions#384
Merged
Conversation
nilmerg
requested changes
May 28, 2026
Member
nilmerg
left a comment
nilmerg
left a comment
There was a problem hiding this comment.
Now that I saw which text you want to show instead, I think showing nothing is the better alternative and this proposal should be changed in order to only show the default placeholder if a suggestion url is set.
Your alternative proposals…
- Enter a column
- Enter a value
…add nothing useful beyond the information added to tell the user no validation is happening. Let's focus on that to make it useful and really helpful instead of repeating such a generic placeholder like these over and over.
BastianLedererIcinga
force-pushed
the
search-editor-placeholders
branch
from
4710975 to
04fdc4c
Compare
nilmerg
reviewed
May 28, 2026
When no suggestions are available the placeholders are misleading
BastianLedererIcinga
force-pushed
the
search-editor-placeholders
branch
from
04fdc4c to
60c81d2
Compare
nilmerg
approved these changes
May 28, 2026
Member
nilmerg
left a comment
nilmerg
left a comment
There was a problem hiding this comment.
Now please also update the title of the PR and we're done :P
BastianLedererIcinga
changed the title
SearchEditorSearchEditor has no suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The placeholders of a
SearchEditorcurrently always stateType to search..., which is rather misleading when an editor is intentionally created without suggestions.The
SearchEditoris adjusted so the placeholders are only shown when suggestions are actually available.