fix(ApiLink): preserve enum member anchor case#41
Open
viktorkombov wants to merge 2 commits into
Open
Conversation
TypeDoc emits PascalCase ids for enum members (e.g. id="Area"). The non-class branch was lowercasing the member, producing dead anchors like #area. Skip the lowercase step when kind === 'enum'.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes ApiLink so enum member anchors remain case-correct (matching TypeDoc’s emitted enum member IDs), avoiding broken links like #area when the actual anchor is #Area.
Changes:
- Preserve enum member anchor casing in the non-class URL branch by skipping the
.toLowerCase()transformation whenkind === 'enum'. - Add an inline comment documenting the TypeDoc enum member anchor casing behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+118
to
+122
| ? member | ||
| : pkgConfig.pascalCaseMembers | ||
| ? member.charAt(0).toUpperCase() + member.slice(1) | ||
| : member.toLowerCase() | ||
| }` |
Comment on lines
115
to
+122
| const memberAnchorNonClass = member | ||
| ? `#${pkgConfig.pascalCaseMembers ? member.charAt(0).toUpperCase() + member.slice(1) : member.toLowerCase()}` | ||
| ? `#${ | ||
| kind === 'enum' | ||
| ? member | ||
| : pkgConfig.pascalCaseMembers | ||
| ? member.charAt(0).toUpperCase() + member.slice(1) | ||
| : member.toLowerCase() | ||
| }` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeDoc emits PascalCase ids for enum members (e.g. id="Area"). The non-class branch was lowercasing the member, producing dead anchors like #area. Skip the lowercase step when kind === 'enum'.