fix(astro): changing remark md links to respect trailingslash rules#199
Open
ChronosSF wants to merge 4 commits into
Open
fix(astro): changing remark md links to respect trailingslash rules#199ChronosSF wants to merge 4 commits into
ChronosSF wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the docs build’s Markdown link rewriting to align generated internal URLs with Astro’s trailingSlash configuration, addressing 404s caused by mismatched trailing-slash behavior (closes #191).
Changes:
- Add
DOCS_TRAILING_SLASHenv propagation from the Astro config options. - Update the remark plugin link rewriting to conditionally include or omit a trailing slash based on
DOCS_TRAILING_SLASH.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/plugins/remark-md-links.ts | Adjusts rewritten .md links to respect configured trailing-slash behavior. |
| src/integration.ts | Exposes Astro trailingSlash setting via process.env for remark/plugin consumption. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #191