POC: bring viv-dicomweb-test work into SLIM and add basic bulk annotations support #381
Open
igoroctaviano wants to merge 10 commits intomasterfrom
Open
POC: bring viv-dicomweb-test work into SLIM and add basic bulk annotations support #381igoroctaviano wants to merge 10 commits intomasterfrom
igoroctaviano wants to merge 10 commits intomasterfrom
Conversation
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Apr 8, 2026 12:46a.m. | Review ↗ |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
POC: bring viv-dicomweb-test work into SLIM and add basic bulk annotations support behind an optional Viv/Deck viewer.
What changed
useViv) alongside the default viewer.src/viv/module (seesrc/viv/README.mdfor limits).Branch & local setup
feat/viv-loader(this PR branch).dicom-microscopy-viewer(DMV) checkout with the matching API changes — not only the npm tarball. From the DMV repo (correct branch for Viv exports): runbun link. Fromslim/, runbun link dicom-microscopy-viewer, thenbun installif needed. Seesrc/viv/README.mdfor the full note; usebun unlink dicom-microscopy-viewerin SLIM when you want registry packages again.How to test
useViv: truehttps://proxy.imaging.datacommons.cancer.gov/current/viewer-only-no-downloads-see-tinyurl-dot-com-slash-3j3d9jyp/dicomWebhttp://localhost:3000/studies/2.25.106918873973188798943205935727506273925/series/1.3.6.1.4.1.5962.99.1.1088146757.1503397867.1637470719301.2.0Possible TODO's
src/viv/: separate network/DICOMweb, decode (DMV), and Deck.gl layer build sodicomLoader/ viewport files don’t keep growing as one mega-module; document the data flow (slide space → deck props) for the next contributor.SlideViewer/VolumeImageViewer; avoid divergent fetch/decode paths in Slim when DMV already exposes the primitives.bun link/file:), and document which DMV release this tracks.viv_example.jsmentioned in README) and short operator-facing notes onuseViv/vivSettingslimits.