⚡ Bolt: Eliminate LINQ and debug log allocations in hot path#34
⚡ Bolt: Eliminate LINQ and debug log allocations in hot path#34lordhippo wants to merge 3 commits into
Conversation
Co-authored-by: lordhippo <5122916+lordhippo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: lordhippo <5122916+lordhippo@users.noreply.github.com>
Co-authored-by: lordhippo <5122916+lordhippo@users.noreply.github.com>
💡 What:
.Where()and.ToList()usage in the per-frame loops ofTeamRunner,Ai, andKnowledge.AttackerDecision.TeamRunnerbehindif (Log.IsEnabled(LogLevel.Debug)).ZLogDebugparameter evaluation in.jules/bolt.md.🎯 Why:
.Select()orstring.Joininside a log call results in heap allocations that happen before the logger's internal log level is evaluated. WhenDebuglogs are disabled, these thousands of allocations are purely wasted compute and garbage.📊 Impact:
TeamRunner.🔬 Measurement:
dotnet-counters monitor -p <PID> --counters System.Runtime[gen-0-gc-count,alloc-rate]PR created automatically by Jules for task 10326074954020290042 started by @lordhippo