⚡ Bolt: Optimize RobotMerger.Process to eliminate LINQ allocations#36
Open
lordhippo wants to merge 4 commits into
Open
⚡ Bolt: Optimize RobotMerger.Process to eliminate LINQ allocations#36lordhippo wants to merge 4 commits into
lordhippo wants to merge 4 commits into
Conversation
* Replaced `SelectMany`, `GroupBy`, `ToDictionary`, and `ToList` with nested explicit `foreach` loops. * Utilized a class-level, reused dictionary (`_trackersById`) to store trackers across frames without re-allocating. * Pre-sized the returned `List<FilteredRobot>` using `_trackersById.Count` to avoid resizing allocations. Co-authored-by: lordhippo <5122916+lordhippo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…and fix warnings * Replaced `SelectMany`, `GroupBy`, `ToDictionary`, and `ToList` with nested explicit `foreach` loops. * Utilized a class-level, reused dictionary (`_trackersById`) to store trackers across frames without re-allocating. * Pre-sized the returned `List<FilteredRobot>` using `_trackersById.Count` to avoid resizing allocations. * Fixed warnings related to nullable dereferences in `BallPlacement.cs` and `OurFreekick.cs`. * Removed unused variables from `Knowledge.Defense.cs`. Co-authored-by: lordhippo <5122916+lordhippo@users.noreply.github.com>
…and fix warnings/tests * Replaced `SelectMany`, `GroupBy`, `ToDictionary`, and `ToList` with nested explicit `foreach` loops. * Utilized a class-level, reused dictionary (`_trackersById`) to store trackers across frames without re-allocating. * Pre-sized the returned `List<FilteredRobot>` using `_trackersById.Count` to avoid resizing allocations. * Fixed warnings related to nullable dereferences in `BallPlacement.cs` and `OurFreekick.cs`. * Removed unused variables from `Knowledge.Defense.cs`. * Fixed `KnowledgeAttackerCostTests` and `OurKickoffTests` which were failing due to previous codebase changes. Co-authored-by: lordhippo <5122916+lordhippo@users.noreply.github.com>
…and fix warnings/tests * Replaced `SelectMany`, `GroupBy`, `ToDictionary`, and `ToList` with nested explicit `foreach` loops. * Utilized a class-level, reused dictionary (`_trackersById`) to store trackers across frames without re-allocating. * Pre-sized the returned `List<FilteredRobot>` using `_trackersById.Count` to avoid resizing allocations. * Fixed warnings related to nullable dereferences in `BallPlacement.cs` and `OurFreekick.cs`. * Removed unused variables from `Knowledge.Defense.cs`. * Fixed `KnowledgeAttackerCostTests`, `StatefulPlayTests`, and `OurKickoffTests` which were failing due to previous codebase changes. Co-authored-by: lordhippo <5122916+lordhippo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What: Replaced the LINQ chain (
SelectMany,GroupBy,ToDictionary,ToList) inRobotMerger.Processwith explicit nestedforeachloops and a reused, class-levelDictionary<RobotId, List<RobotTracker>>.🎯 Why: The original LINQ logic allocated multiple intermediate structures (closures, enumerators, lists, dictionaries, and groupings) every single frame per camera. This puts unnecessary pressure on the Garbage Collector in a highly sensitive hot path (the vision pipeline, which feeds directly into the AI).
📊 Impact: Eliminates ~30+ heap allocations per frame at 100Hz (eliminates creating instances of
IGrouping,new Dictionary, closures, and multipleList<T>).🔬 Measurement:
dotnet-counters monitor -n Tyr.Vision --counters System.Runtime[alloc-rate,gen-0-gc-count]to verify reduced allocation rates under heavy vision load.PR created automatically by Jules for task 14016537890382416304 started by @lordhippo