-
Notifications
You must be signed in to change notification settings - Fork 4
[자동차 경주] 박시영 미션 제출합니다. #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
player7571
wants to merge
14
commits into
InQ-InQ-InQ-InQ-InQ:main
Choose a base branch
from
player7571:siyoung
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7bfb034
feat: 경주할 자동차 입력 기능 추가
player7571 906e134
feat: 시도회수 입력 기능 추가
player7571 249d53f
feat: 실행 결과 출력 추가
player7571 cc79944
feat: 우승자 출력기능 추가
player7571 b621f47
fix: 필요없는 매개변수 삭제
player7571 3405b05
fix: 중복 코드 삭제
player7571 46f9f20
add README.md
player7571 1966802
Merge branch 'InQ-InQ-InQ-InQ-InQ:main' into siyoung
player7571 df2a5a2
fix: 라이브러리 변경
player7571 7e93bb7
style: 코드 정리
player7571 858e14a
fix: 피드백 바탕으로 변수명 변경, 이동거리및 최대 이동거리 최신화 하는 메서드 분리
player7571 06a7da1
fix: 우승자를 전부 뽑은 후 한번에 문자열로 반환하도록 변경
player7571 c5b3d53
fix: car[] distance[] 배열 제거 후 Car 객체 추가 후 코드 수정
player7571 468d82b
feat: controller 분리
player7571 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| package racingcar; | ||
|
|
||
| public class Controller { | ||
|
|
||
| Model model = new Model(); | ||
| View view = new View(); | ||
|
|
||
| void run(){ | ||
| model.saveCarName(view.inputCarName()); | ||
|
|
||
| model.saveNumberOfAttempts(view.inputNumberOfAttempts()); | ||
|
|
||
| view.printResult(model.race()); | ||
|
|
||
| view.printWinner(model.findWinner()); | ||
| } | ||
|
|
||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 깔끔하게 변경 잘된거 같아요