Fix outstanding pre-release issues#25
Open
salcock wants to merge 18 commits into
Open
Conversation
Also fixed some bugs in the configurable RV and RIS endpoint URLs, where the env variables were not being loaded before bgpfinder tries to use them.
Updated routeviews and ris finders to inherit from the BaseFinder class. Re-factor main scraping method to be more modular and easier to understand (with less indentation).
This ensures backwards compatibility with (buggy) behavior in the CAIDA bgpstream broker. Data requests with a dataAddedSince of 0 will continue to apply the "dataAddedSince" that is requested.
Also replace README with something more appropriate for a complete project.
This ensures optional .env variables are handled properly in the containers.
This ensures that an initial deployment will populate its collectors table right away without manual intervention.
* don't apply result cap to scrapes, only to user requests. * ensure scrape timestamps only move forward in time * set default collector scrape timestamps to unixts(0)
Remove deprecated "version" from docker-compose.yaml
Enable use of "host:port,host2:port2" syntax for specifying multiple hosts. Automatically add `target_session_attrs=read-write` to connection strings for the scraper so it doesn't try to write to a readonly replica.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically:
humanparameter in the data/ API #21)