Skip to content

[Feature] review-bot: add bugfix PR checklist for regression coverage #93

Closed

Description

@yenuo26

Summary

希望机器人在评审 bugfix PR 时,把「用例覆盖是否全面」以及「用例是否已经覆盖该 bug 的验证」纳入正式评审条例,并在 review 评论中给出可执行结论。

Motivation

  • 仅修代码、不补回归用例,容易导致同类问题复发
  • 现有 review 更偏 correctness / design,对「是否验证原 bug」检查不够硬
  • 希望 bugfix 合入前强制确认:失败路径已被测试钉住

Proposed review rules

当 PR 被识别为 bugfix(标题/标签/描述/关联 issue)时,机器人额外检查:

  1. 用例是否覆盖该 bug
    • 是否新增或更新了能复现原问题的回归用例
    • 用例失败条件是否与 bug 根因/触发路径对齐,而不是只测 happy path
  2. 覆盖是否全面
    • 相关边界、同类入口、相邻失败模式是否有基本覆盖
    • 若无法补测,PR 是否明确说明原因与剩余风险
  3. 验证证据
    • review 评论中指出命中的测试文件/用例,或明确标出缺失项为 blocking / non-blocking

Acceptance criteria

  • bugfix PR 触发专用评审条例(非 bugfix 不受影响)
  • review 输出包含「是否覆盖原 bug」与「覆盖完整性」两项结论
  • 缺少回归验证时,能给出可操作的 finding(指向应补测的行为/路径)
  • 与现有 Direct / Strict review 流程可集成,不另起冲突的审查通道

Out of scope

  • 不要求机器人自动生成完整测试实现
  • 不替代人工对复杂 flaky / 环境依赖用例的最终判断

Activity

  1. added a commit that references this issue on Aug 25, 2026
  2. tzhouam commented on Sep 29, 2026

    @tzhouam
    Collaborator

    Shipped: Phase 1 of the bugfix regression-coverage checklist in #105, plus the test-evidence and size rules in #148/#149 and JiusiServe/omni-reviewbot#56/#57. Phase 2 (a deterministic bugfix classifier making Strict injection conditional) was contingent on a trial; open a new issue if it is still wanted. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions