Repository navigation
audit: re-pin previous_audited_sha to a commit upstream still has - #143
Conversation
vllm-omni rewrote its main after 2026-09-05: the audited baseline's `previous_audited_sha` (1015b1ced, "rebase: align vllm-omni with vLLM d2906cc19586") is no longer reachable from any upstream ref, so every pull_request run of the release drift audit dies at `git rev-parse` with "Needed a single revision" before auditing anything (first seen on #140). Pin `previous_audited_sha` to 66bbebd9d, the merge base of the lost commit and current upstream main. `audited_sha` (44d3ae1) is unchanged and still on main. Verified locally against a fresh upstream clone: audit 66bbebd9 -> 44d3ae10, enforce: issues 0, RESULT: CLEAN Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MAFmwP3u5qAMDgHfM6LFi
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca258ddbdf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| upstream: | ||
| repository: vllm-project/vllm-omni | ||
| previous_audited_sha: 1015b1ced073195ed19f0610264dfdf8a8150e6c | ||
| previous_audited_sha: 66bbebd9d3ef669b93fd7e39587672b20efc5933 |
There was a problem hiding this comment.
If a knowledge page cites a path that existed in the former 1015b1ce snapshot after it diverged from 66bbebd9, but is absent from 44d3ae10, this re-pin makes the enforce audit accept that stale source: _knowledge_source_issues only reports a source when it exists in old_files, and the new merge-base snapshot does not contain those branch-only paths. Preserve the former snapshot's source inventory or strengthen the audit to validate every upstream sources: entry against the target before changing this pin.
AGENTS.md reference: AGENTS.md:L25-L29
Useful? React with 👍 / 👎.
Why
vllm-omni rewrote its
mainafter 2026-09-05. The baseline'sprevious_audited_sha(1015b1ced, "rebase: align vllm-omni with vLLM d2906cc19586") is no longer reachable from any upstream ref, so thepull_requestrun of the release drift audit fails atgit rev-parsewithNeeded a single revisionon every PR (first seen on #140), before auditing anything.What
Pin
previous_audited_shato66bbebd9d, the merge base of the lost commit and current upstreammain.audited_sha(44d3ae1) is unchanged and still onmain.Verification
Local run against a fresh upstream clone:
The audit workflow on this PR exercises the same range.
🤖 Generated with Claude Code
https://claude.ai/code/session_018MAFmwP3u5qAMDgHfM6LFi