Repository navigation
Gate PR mutation on reviewed commits and clarify evidence contracts - #186
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69e46881b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
|
|
||
| BUGFIX_RECORD_MARKER = "<!-- infermatrix-copilot:bugfix-record:v1 -->" | ||
| BUGFIX_RECORD_MARKER = "<!-- infermatrix-copilot:bugfix-record:v2 -->" |
There was a problem hiding this comment.
When repo_full_names lacks an alias, the producer deliberately emits a schema-v1 record without event_id or repository, but _publish_intake_record now labels every record with the v2 marker. Legacy mailbox consumers scan for the documented v1 marker (doc/RFC-knowledge-intake.md:219), while a v2 parser may require the new identity fields, so these compatibility records are silently skipped or rejected. Select the marker from the record's schema_version rather than using one unconditional v2 constant.
Useful? React with 👍 / 👎.
PR debug and rebase could approve a clean working tree without reviewing the commits about to be pushed. This change freezes an explicit committed base/head range, reviews that range, and rejects a push when HEAD has changed since approval. It also serializes mutating debug groups, requires an observed clean commit and verification evidence, honors the requested group cap, and skips checkout for debug report-only runs.
The playbook and profile stores now reject malformed inputs without losing later valid operations. Rebase advisory answers distinguish verified, problem, and inconclusive. Landed-fix evidence carries a versioned canonical repository identity when configured, while older alias-only producers remain readable by explicit legacy consumers. The SDK spec now describes the existing carried-finding recheck contract.
Validation: complete offline suite, 1,525 passed (one pre-existing Pydantic warning); focused PR/engine/knowledge tests and SPEC/doc integrity checks passed. Git diff is clean.