Repository navigation
Split knowledge curation by domain responsibility - #189
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public knowledge-curation facade is thin, but its internal implementation still combines catalog discovery, prompt construction, proposal validation, and transactional apply in one 1,123-line module. This splits those responsibilities into internal components and leaves
KnowledgeCuratoras the composed application entry point. Shared rule syntax, bounds, hashing, and lock capability live in one common module; the public SDK class and error imports stay unchanged.The apply component still owns the in-process/interprocess lock, stale-page and tree-wide ID rechecks, fixed validator order, and byte-exact rollback. No model, Git publication, CLI, or MCP dependency is introduced. A package SPEC records the ownership and compatibility invariants.
Validation: 1,528 local tests passed; 61 focused SDK/curation tests passed; strict SPEC freshness reports zero stale or uncovered modules; an installed-wheel curation smoke passed; Ruff F401/F821 checks passed on the new package.