Repository navigation
Include published inline findings in archived review replay - #200
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The archived ReviewBot quality replay previously judged only its review-body artifact. When a finding was placed as an inline GitHub comment, that artifact said “See inline comments below” but omitted the comment itself; PR #4810 was one such case, so the evaluation could falsely score a valid finding as absent.
The evaluation-only adapter now captures the exact inline payload from the installed publisher and appends it to the shadow artifact. It checks the publisher's inline count and the artifact's state-directory path before writing. Production publication and the paired wheels are unchanged. The adapter fingerprint in each arm manifest changes, so old and corrected campaigns cannot mix.
Validation: 65 focused evaluation tests passed. A one-item replay of archived PR #4810 with the installed ReviewBot
49ad12bc/ Copilot5109fd2bpair passed the shadow, head, frozen-file, no-discussion, and output-cap guards. Its corrected artifact included the inline finding about the omitted HunyuanImage3 loader, matching the frozen latent-gap note. This is a validity smoke, not a review-quality estimate.